From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andrew Morton <akpm@osdl.org>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] problem of cont_prepare_write()
Date: Mon, 22 Nov 2004 20:38:12 +0900 [thread overview]
Message-ID: <87ekimw1uj.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20041122024654.37eb5f3d.akpm@osdl.org> (Andrew Morton's message of "Mon, 22 Nov 2004 02:46:54 -0800")
Andrew Morton <akpm@osdl.org> writes:
> Perhaps cont_prepare_write() should look to see if the zerofilled page is
> outside the current i_size and if so, advance i_size to the end of the
> zerofilled page prior to releasing the page lock.
Yes, my first patch was it.
Umm... however, if ->i_size is updated before ->commit_write(),
doesn't it allow access to those pages, before all write() work is
successful?
Doesn't this cause strange behavior?
(especially a failure case of prepare_write())
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2004-11-22 11:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-22 10:30 [RFC][PATCH] problem of cont_prepare_write() OGAWA Hirofumi
2004-11-22 10:41 ` Andrew Morton
2004-11-22 10:46 ` Andrew Morton
2004-11-22 11:03 ` Anton Altaparmakov
2004-11-22 21:53 ` Andrew Morton
2004-11-22 23:30 ` Anton Altaparmakov
2004-11-22 23:43 ` Andrew Morton
2005-01-13 14:47 ` write barriers - Was: " Anton Altaparmakov
2005-01-13 15:56 ` Chris Friesen
2005-01-13 18:08 ` Florian Weimer
2004-11-22 11:38 ` OGAWA Hirofumi [this message]
2004-11-22 21:43 ` Andrew Morton
2004-11-23 2:22 ` OGAWA Hirofumi
2004-11-23 2:30 ` Andrew Morton
2004-11-23 2:55 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ekimw1uj.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.