All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fumitoshi UKAI <ukai@debian.or.jp>
To: linux-hotplug@vger.kernel.org
Subject: usb cold plugging
Date: Sun, 14 Mar 2004 17:58:40 +0000	[thread overview]
Message-ID: <87ekrv71kf.wl@ukai.org> (raw)

Hi,

It seems there are some problems in usb coldplugging.

1) after usb core modules loaded, it needs some time to propagate
  information to /proc or /sys. So, I think we need some wait before
  calling usb_boot_events.
  But I'm not sure it is sufficient to sleep 1 sec. are there any 
  better way to wait some files in /proc or /sys ?

2) if /sys/bus/usb/devices found, it updates DEVPATH and PRODUCT, but
   it never call /etc/hotplug/usb.agent, so no coldplugging happens.

Is this patch ok to commit?

diff -ruN hotplug-2004_03_11.orig/etc/hotplug/usb.rc hotplug-2004_03_11/etc/hotplug/usb.rc
--- hotplug-2004_03_11.orig/etc/hotplug/usb.rc	2004-03-15 01:44:51.000000000 +0900
+++ hotplug-2004_03_11/etc/hotplug/usb.rc	2004-03-15 01:44:26.000000000 +0900
@@ -103,13 +103,9 @@
 	    for device in /sys/bus/usb/devices/[0-9]*; do
 		DEVPATH=${device#/sys/}
 		if [ -f $device/idVendor ]; then
-		     PRODUCT="`cat $device/idVendor`/`cat $device/idProduct`/`cat $device/bcdDevice`"
-#		    class=`cat $device/bDeviceClass`
-#		    TYPE="$class/`cat $device/bDeviceSubClass`/`cat $device/bDeviceProtocol`"
+		     PRODUCT="$(cat $device/idVendor)/$(cat $device/idProduct)/$(cat $device/bcdDevice)"
+		     /etc/hotplug/usb.agent
 		fi
-#		if [ "$class" -eq 0 -a -f $device/bInterfaceClass ]; then
-#		    INTERFACE="`cat $device/bInterfaceClass`/`cat $device/bInterfaceSubClass`/`cat $device/bInterfaceProtocol`"
-#		fi
 	    done
 	else
 	    for DEVICE in /proc/bus/usb/*/*; do
@@ -208,6 +204,7 @@
     # cope with devices that enumerated earlier
     # and may not have been fully configured.
     if [ $SYNTHESIZE = true ]; then
+	sleep 1
     	usb_boot_events
     fi
 

Thanks,
Fumitoshi UKAI


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

             reply	other threads:[~2004-03-14 17:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-14 17:58 Fumitoshi UKAI [this message]
2004-03-26 23:15 ` usb cold plugging Greg KH
2004-03-27  7:56 ` Fumitoshi UKAI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ekrv71kf.wl@ukai.org \
    --to=ukai@debian.or.jp \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.