From: Olaf Dietsche <olaf.dietsche@t-online.de>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] restore modules compatibility
Date: Wed, 22 Jan 2003 01:15:08 +0100 [thread overview]
Message-ID: <87el76avlf.fsf@goat.bogus.local> (raw)
In-Reply-To: Pine.LNX.4.44.0301211749390.5658-100000@spit.local
Roman Zippel <zippel@linux-m68k.org> writes:
> The patch below does two things:
> 1. The new param stuff suffers from serious bloat, I replaced it with a
> much simpler implementation. The interesting feature here is that even
> without changing any module all parameters are reachable from the command
> line via "<modname>.<param>=..."
> 2. I added the old module system calls back and modules are now installed
> with the ".o" suffix again, so the old modutils are working again. Special
> feature here is that the same module should be loadable with either module
> tools.
>
> The patch is against 2.5.59-um, if you don't have Jeffs patch just ignore
> the single reject.
It doesn't apply cleanly to 2.5.59, nor does it apply to 2.5.59-um:
patching file Makefile
patching file arch/i386/kernel/entry.S
Hunk #1 FAILED at 669.
1 out of 2 hunks FAILED -- saving rejects to file arch/i386/kernel/entry.S.rej
patching file arch/um/kernel/sys_call_table.c
patching file fs/proc/proc_misc.c
patching file include/asm-generic/vmlinux.lds.h
can't find file to patch at input line 132
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -ur -X /home/roman/nodiff linux-2.5.59.org/include/asm-um/common.lds.S linux-2.5.59/include/asm-um/common.lds.S
|--- linux-2.5.59.org/include/asm-um/common.lds.S 2003-01-21 16:55:00.000000000 +0100
|+++ linux-2.5.59/include/asm-um/common.lds.S 2003-01-20 21:19:40.000000000 +0100
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored
patching file include/linux/module.h
patching file include/linux/moduleparam.h
patching file kernel/module.c
Hunk #1 FAILED at 68.
Hunk #8 FAILED at 550.
Hunk #18 FAILED at 1246.
3 out of 20 hunks FAILED -- saving rejects to file kernel/module.c.rej
patching file kernel/params.c
Hunk #2 FAILED at 28.
1 out of 4 hunks FAILED -- saving rejects to file kernel/params.c.rej
patching file scripts/Makefile.modinst
patching file modules.lds
entry.S(672): missing space at end of line
module.c(84): missing space at end of line
...
Although, "patch -l" applies without failures.
Regards, Olaf.
next prev parent reply other threads:[~2003-01-22 0:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-21 18:28 [PATCH] restore modules compatibility Roman Zippel
2003-01-22 0:15 ` Olaf Dietsche [this message]
2003-01-22 2:56 ` Roman Zippel
2003-01-22 8:44 ` Olaf Dietsche
2003-01-22 18:25 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87el76avlf.fsf@goat.bogus.local \
--to=olaf.dietsche@t-online.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.