From: Johannes Berg <johannes@sipsolutions.net>
To: Slawomir Stepien <sst@poczta.fm>
Cc: syzkaller-bugs@googlegroups.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, syzbot@lists.linux.dev,
syzbot+9bdc0c5998ab45b05030@syzkaller.appspotmail.com
Subject: Re: [PATCH 3/3] wifi: cfg80211: check if AP has been started before adding new station
Date: Mon, 07 Sep 2026 11:47:16 +0200 [thread overview]
Message-ID: <87f5112aeea92eb84350eaa19ef8ccdf4c630c96.camel@sipsolutions.net> (raw)
In-Reply-To: <ap6H7U3j0CgPj2IR@nr200>
On Mon, 2026-09-07 at 11:46 +0200, Slawomir Stepien wrote:
> On wrz 04, 2026 11:25, Johannes Berg wrote:
> > On Thu, 2026-08-13 at 11:04 +0200, Slawomir Stepien wrote:
> > >
> > > case NL80211_IFTYPE_P2P_GO:
> > > + /* Add a new station only after the AP and link has been started */
> > > + link_id = wdev->valid_links ? params.link_sta_params.link_id : 0;
> >
> > max() maybe?
>
> But wouldn't that blur the intent here? It's not about a bigger value. It's about MLO or not MLO
> device handling.
Yeah, true, was thinking more of the pattern than the semantics.
johannes
next prev parent reply other threads:[~2026-09-07 9:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 9:04 [PATCH 1/3] wifi: cfg80211: do not support direct add of station to AP_VLAN interfaces Slawomir Stepien
2026-08-13 9:04 ` [PATCH 2/3] wifi: cfg80211: move link_id validation earlier in nl80211_new_station() Slawomir Stepien
2026-08-13 9:04 ` [PATCH 3/3] wifi: cfg80211: check if AP has been started before adding new station Slawomir Stepien
2026-09-04 9:25 ` Johannes Berg
2026-09-07 9:46 ` Slawomir Stepien
2026-09-07 9:47 ` Johannes Berg [this message]
2026-09-08 9:44 ` Slawomir Stepien
2026-09-08 9:46 ` Johannes Berg
2026-09-08 11:59 ` Slawomir Stepien
2026-09-08 12:25 ` Johannes Berg
2026-09-08 13:35 ` Slawomir Stepien
2026-09-08 13:37 ` Johannes Berg
2026-08-13 13:31 ` [syzbot ci] Re: wifi: cfg80211: do not support direct add of station to AP_VLAN interfaces syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87f5112aeea92eb84350eaa19ef8ccdf4c630c96.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sst@poczta.fm \
--cc=syzbot+9bdc0c5998ab45b05030@syzkaller.appspotmail.com \
--cc=syzbot@lists.linux.dev \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.