All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Owens James <hechushiguitu666@gmail.com>
Cc: Viresh Kumar <vireshk@kernel.org>,
	Niklas Cassel <cassel@kernel.org>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: pata_arasan_cf: fix missing newline in dev_err messages
Date: Thu, 2 Apr 2026 16:38:20 +0900	[thread overview]
Message-ID: <87f5a30f-0b81-4c88-bd33-c89970021ec5@kernel.org> (raw)
In-Reply-To: <CAEZ4rQ8QMQ8q0ev2oSmVUoFw=02Sp5BEqTjzr_=Y+pv8Uk8osw@mail.gmail.com>

On 2026/04/02 16:11, Owens James wrote:
> Hi Damien,
> 
> Thank you for checking!
> The function arasan_cf_xfer() does exist in the mainline kernel at
> drivers/ata/pata_arasan_cf.c around line 380.

Nope...

378 static inline int wait4buf(struct arasan_cf_dev *acdev)
379 {
380         if (!wait_for_completion_timeout(&acdev->cf_completion, TIMEOUT)) {
381                 u32 rw = acdev->qc->tf.flags & ATA_TFLAG_WRITE;
382
383                 dev_err(acdev->host->dev, "%s TimeOut\n", rw ? "write" :
"read");
384                 return -ETIMEDOUT;
385         }
386
387         /* Check if PIO Error interrupt has occurred */
388         if (acdev->dma_status & ATA_DMA_ERR)
389                 return -EAGAIN;
390
391         return 0;
392 }

And "git grep arasan_cf_xfer" gives nothing.

So still not sure which kernel you are looking at.

> This patch is based on the latest upstream mainline branch.
> Please let me know if you need anything else.

Patches for libata should be based off libata/for-next or libata/for-7.1.


-- 
Damien Le Moal
Western Digital Research

  reply	other threads:[~2026-04-02  7:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02  2:10 [PATCH] ata: pata_arasan_cf: fix missing newline in dev_err messages Haoyu Lu
2026-04-02  3:00 ` Viresh Kumar
2026-04-02  5:35 ` Damien Le Moal
2026-04-02  7:11   ` Owens James
2026-04-02  7:38     ` Damien Le Moal [this message]
2026-04-02  7:48       ` Haoyu Lu
2026-04-02  8:27         ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87f5a30f-0b81-4c88-bd33-c89970021ec5@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cassel@kernel.org \
    --cc=hechushiguitu666@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.