Re: [PATCH mptcp-next] selftests: mptcp: validate userspace PM tests by default

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Wed, 6 Jul 2022, Matthieu Baerts wrote:

> The new script was not listed in the programs to test.
>
> By concequence, some CIs running MPTCP selftests were not validating
> these new tests. Note that MPTCP CI was validating it as it executes all
> .sh scripts from 'tools/testing/selftests/net/mptcp' directory.
>
> Fixes: 259a834fadda ("selftests: mptcp: functional tests for the userspace PM type")
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> ---
> tools/testing/selftests/net/mptcp/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/Makefile b/tools/testing/selftests/net/mptcp/Makefile
> index f905d5358e68..48a99e1453e1 100644
> --- a/tools/testing/selftests/net/mptcp/Makefile
> +++ b/tools/testing/selftests/net/mptcp/Makefile
> @@ -6,7 +6,7 @@ KSFT_KHDR_INSTALL := 1
> CFLAGS =  -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include $(KHDR_INCLUDES)
>
> TEST_PROGS := mptcp_connect.sh pm_netlink.sh mptcp_join.sh diag.sh \
> -	      simult_flows.sh mptcp_sockopt.sh
> +	      simult_flows.sh mptcp_sockopt.sh userspace_pm.sh
>
> TEST_GEN_FILES = mptcp_connect pm_nl_ctl mptcp_sockopt mptcp_inq
>
> -- 
> 2.36.1

Thanks for quickly acting on Jakub's note. Might end up sending this for 
-net too. I don't think it should conflict so where you put it in the 
export branch probably doesn't matter too much.

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

--
Mat Martineau
Intel