From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: netdev-bot+sashiko@kernel.org
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, afd@ti.com, andrew@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk,
michal.simek@amd.com, edumazet@kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v4 1/4] dt-bindings: net: dp83867: add compatible and reference ethernet-phy.yaml
Date: Mon, 16 Nov 2026 08:08:21 +0100 [thread overview]
Message-ID: <87fqx145ju.fsf@pengutronix.de> (raw)
In-Reply-To: <179465553656.2199510.11430097651218280926@kernel.org>
On 2026-11-14 at 11:25 GMT, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] This patch adds `select: properties: compatible: contains:
> const: ethernet-phy-id2000.a231` to…
>
> --
>
> dt-bindings: net: dp83867: add compatible and reference ethernet-phy.yaml
>
> This patch adds a compatible for the DP83867 PHY ID, with an optional
> ethernet-phy-ieee802.3-c22 fallback. It also adds a select on the PHY ID,
> so dtschema now applies the binding to nodes. The $ref changes from
> ethernet-controller.yaml to ethernet-phy.yaml.
>
> > diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> > index 4bc1f98fd9fe5..2cd8311ece5e5 100644
> > --- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> > +++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> > @@ -8,7 +8,16 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> > title: TI DP83867 ethernet PHY
> >
> > allOf:
> > - - $ref: ethernet-controller.yaml#
> > + - $ref: ethernet-phy.yaml#
> > +
> > +# only the PHY ID, not every PHY with the c22 fallback
> > +select:
> > + properties:
> > + compatible:
> > + contains:
> > + const: ethernet-phy-id2000.a231
> > + required:
> > + - compatible
>
> [Severity: Medium]
> With this select, the schema now applies to every in-tree node that has
> "ethernet-phy-id2000.a231". The binding still ends with:
>
> unevaluatedProperties: false
>
> Several Xilinx ZynqMP devicetrees set #phy-cells on their DP83867 nodes.
> For example, arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts has:
>
> phy0: ethernet-phy@21 {
> #phy-cells = <1>;
> compatible = "ethernet-phy-id2000.a231";
>
> The same pattern is in zynqmp-zcu102-revB.dts, zynqmp-zcu104-revA.dts,
> zynqmp-zcu104-revC.dts, zynqmp-zcu106-revA.dts, zynqmp-zcu111-revA.dts,
> zynqmp-sck-kv-g-revA.dtso and zynqmp-sck-kv-g-revB.dtso. It is also in
> zynqmp-sck-kr-g-revA.dtso and zynqmp-sck-kr-g-revB.dtso, with two PHYs
> in each.
>
> #phy-cells is not defined in ti,dp83867.yaml or in ethernet-phy.yaml. With
> this patch, will make dtbs_check report "Unevaluated properties are not
> allowed ('#phy-cells' was unexpected)" for all 12 of these nodes?
>
> The commit message says:
>
> Reference
> ethernet-phy.yaml instead, which also describes reset-gpios and the
> other generic PHY properties existing devicetrees use.
>
> That doesn't seem to hold for #phy-cells.
>
> The later patches in the series keep the select and
> unevaluatedProperties: false. They don't change these DTS files either, so
> the mismatch is still there at the end of the series.
>
> Should the series either drop #phy-cells from the Xilinx devicetrees, or
> allow it in the schema? It looks bogus on an MDIO PHY that isn't a generic
> PHY provider.
>
> [ ... ]
This is fixed with the patch from
Message-Id: <20261110-v7-4-topic-zynqmp-dp83867-v1-1-04500475a560@pengutronix.de>
which is already applied to the xilinx tree.
str
--
Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2026-11-16 7:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 10:20 [PATCH net-next v4 0/4] net: dp83867: add new output-impedance DT binding Steffen Trumtrar
2026-11-10 10:20 ` [PATCH net-next v4 1/4] dt-bindings: net: dp83867: add compatible and reference ethernet-phy.yaml Steffen Trumtrar
2026-11-14 11:25 ` netdev-bot+sashiko
2026-11-16 7:08 ` Steffen Trumtrar [this message]
2026-11-10 10:20 ` [PATCH net-next v4 2/4] dt-bindings: net: dp83867: make exclusivity explicit Steffen Trumtrar
2026-11-10 10:20 ` [PATCH net-next v4 3/4] dt-bindings: net: dp83867: Add ti,output-impedance-ohms Steffen Trumtrar
2026-11-10 10:20 ` [PATCH net-next v4 4/4] net: phy: dp83867: support setting output-impedance Steffen Trumtrar
2026-11-14 11:25 ` netdev-bot+sashiko
2026-11-14 14:54 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fqx145ju.fsf@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=afd@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@amd.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.