Re: [PATCH i-g-t 0/2] Fix igt_runner hang and resource leak associated with pw-reserve

[Gustavo Sousa <gustavo.sousa@intel.com>]

Gustavo Sousa <gustavo.sousa@intel.com> writes:

> When running igt_runner on an interactive SSH session we realized that
> the runner would hang when testlists contained test cases that would
> unbind/rebind (or unload/reload) the driver multiple times.
>
> Some debugging revealed that the hangs were caused by pw-reserve
> processes created by IGT not being properly terminated.  Let's fix
> that.
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
>

Please disregard the patch text below.  This should have been only a
cover letter.  Something clearly went wrong when I was editing the cover
letter. Sorry about that.

That said, I think the real patches (patch #1 and #2) are still
reviewable, so I'll wait for feedback on them instead of sending another
version only with the text below removed.

Hopefully this doesn't confuse CI!

--
Gustavo Sousa

> diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> index dbb90756babc..18053db8ff46 100644
> --- a/lib/igt_aux.c
> +++ b/lib/igt_aux.c
> @@ -1898,13 +1898,10 @@ static void pipewire_reserve_wait(void)
>  		setenv("HOME", homedir, 1);
>  		setenv("XDG_RUNTIME_DIR",xdg_dir, 1);
>  
> -		/*
> -		 * pw-reserve will run in background. It will only exit when
> -		 * igt_kill_children() is called later on. So, it shouldn't
> -		 * call igt_waitchildren(). Instead, just exit with the return
> -		 * code from pw-reserve.
> -		 */
> -		exit(system("pw-reserve -n Audio0 -r"));
> +		if (execlp("pw-reserve", "pw-reserve", "-n", "Audio0", "-r", NULL)) {
> +			igt_warn("Failed to start pw-reserve: %s\n", strerror(errno));
> +			exit(1);
> +		}
>  	}
>  }
>  
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> ---
> Gustavo Sousa (2):
>       lib/igt_core: Check if helper proc was alive before kill()
>       lib/igt_aux: Call pw-reserve with execlp()
>
>  lib/igt_aux.c  | 11 ++++-------
>  lib/igt_core.c | 20 +++++++++-----------
>  2 files changed, 13 insertions(+), 18 deletions(-)
> ---
> base-commit: faad2cd0e3e8eb2e18111c2358823a7bdfb56d94
> change-id: 20261006-stop-pw-reserve-ae63047af2d4
>
> Best regards,
> --  
> Gustavo Sousa <gustavo.sousa@intel.com>