Re: [PATCH] ALSA: hda/realtek: Enable mute LEDs on HP OmniBook 7 17-dc0xxx

[Takashi Iwai <tiwai@suse.de>]

On Mon, 14 Sep 2026 16:24:42 +0200,
Jaeho Cho wrote:
> 
> The HP OmniBook 7 Laptop 17-dc0xxx (SSID 103c:8d9c) has mute and
> mic-mute LEDs on its F6 and F9 keys, but neither lights up. Its quirk
> entry only sets up the two CS35L41 amplifiers, so no LED control is
> registered for either key.
> 
> Writing to the ALC245 by hand with hda-verb, the mute LED responds to
> COEF 0x0b bits 2-3 and the mic-mute LED to GPIO 0x04, lit when the pin
> is low. That appears to match what ALC245_FIXUP_HP_X360_MUTE_LEDS
> already does, so add a fixup that chains the two-amp I2C setup to it
> and use it for this model.
> 
> Tested on 7.2.4 with the patched module: hda::mute and hda::micmute
> are registered, and both LEDs follow the speaker and microphone mute
> state, including from the F6 and F9 keys.
> 
> Signed-off-by: Jaeho Cho <jaeho2025@gmail.com>
> ---
> Hi Takashi,
> 
> I found the LED wiring by trial and error rather than from any HP or Realtek documentation, so there may be details I am missing. A few things I was unsure about:
> 
> - Setting COEF 0x35 bit 6 also lit the mic-mute LED. I went with GPIO 0x04 because it matches the existing HP fixups, but I do not know which one HP's own driver uses, or whether it matters.
> 
> - The sibling models 8d9b ("OmniBook 7 UMA") and 8d9d/8d9e ("OmniBook X") probably share this board, but I only have the 8d9c to test on, so I left them unchanged.
> 
> I am happy to revise anything that should be done differently. Thank you for your time, and for maintaining this driver.

The patch looks simple enough, so I applied now.


thanks,

Takashi