From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B81A4C624DE for ; Fri, 4 Sep 2026 11:56:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x2SVx-0001y9-BY; Fri, 04 Sep 2026 07:55:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x2SVu-0001wq-Vn for qemu-devel@nongnu.org; Fri, 04 Sep 2026 07:55:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x2SVt-0002zu-Iz for qemu-devel@nongnu.org; Fri, 04 Sep 2026 07:55:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788522920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0lr9ONnTXv/gmp71FY7fCTVNOLNFpw4U563tnD9ly/g=; b=e2oNJGOsv3JeVHulQDBbCCYQGKSGHvj2c9zjO1Drh9fnckyFJabGB8/KuptHN5zDUMBKzt cuQ0bqshg4vMzoidqQJZedISH/wSG59yHOtZJ3h3BwyZZdaYyh7LScyulci7LzxdnA9o47 7IBFojlUZPzH3VtSzmv1NNIVI5VAVvA= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-144-CcwljbP4OVCDN_KgUapL0w-1; Fri, 04 Sep 2026 07:55:17 -0400 X-MC-Unique: CcwljbP4OVCDN_KgUapL0w-1 X-Mimecast-MFC-AGG-ID: CcwljbP4OVCDN_KgUapL0w_1788522915 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3B34318869A1; Fri, 4 Sep 2026 11:55:15 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.5]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5EFD01800598; Fri, 4 Sep 2026 11:55:14 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id EB8CC21E6A04; Fri, 04 Sep 2026 13:55:11 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: Markus Armbruster , Peter Maydell , luoyonggang@gmail.com, Pierrick Bouvier , qemu-devel@nongnu.org, anjo@rev.ng, Daniel Henrique Barboza , philmd@oss.qualcomm.com, Paolo Bonzini , Richard Henderson Subject: Re: [PATCH 00/47] single-binary: implement dynamic filtering for QOM types In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Fri, 4 Sep 2026 12:27:15 +0100") References: <20260828225901.367438-1-pierrick.bouvier@oss.qualcomm.com> <4b4f77ee-21e9-405e-a1da-21506afa1c5b@oss.qualcomm.com> <87h5k58ds8.fsf@pond.sub.org> Date: Fri, 04 Sep 2026 13:55:11 +0200 Message-ID: <87fqzp6xk0.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > On Fri, Sep 04, 2026 at 01:19:19PM +0200, Markus Armbruster wrote: >> Daniel P. Berrang=C3=A9 writes: [...] >> > IMHO it is best if our goal is to ensure type names are unique >> > throughout the codebase, so hopefully we don't have clashing >> > device names. >>=20 >> Yes. >>=20 >> Quick glance at type_new(): >>=20 >> if (type_table_lookup(info->name) !=3D NULL) { >> fprintf(stderr, "Registering `%s' which already exists\n", info-= >name); >> abort(); >> } >>=20 >> If we have duplicate type names, they won't survive being linked >> together in a single binary. > > If we want perfect testing coverage, then the main constraint here > is how quickly we get to a point where 'qemu-system' can build with > all targets. I don't that's a show stopper though, as the uniqueness > only becomes a real problem as we enable each new target in the single > binary. We don't appear to have many examples of existing clashes to > suggest it is a major problem to solve any sooner. Agree!