From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00332C44529 for ; Mon, 20 Jul 2026 20:22:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7AFC310E184; Mon, 20 Jul 2026 20:22:42 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="gH5cv9vr"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23CA710E184 for ; Mon, 20 Jul 2026 20:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784578930; x=1816114930; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=EDO92xmcMFpBr7bWF2tBwwFYzg62ElKdx9GU1ShZu4o=; b=gH5cv9vrWBLrP477yciXFSlZ+L2+X3Id5ImmZSSbYu+UUqU8qqWw7QDI 7PwucNyodR2XsUn5c0Vhnhj0TgXf8HNBULb8wqU7dO56sial51L/tJkX/ +7oQy+KQHX8kGqVJNSjkZVyYwON9jYkq1H6RgjNWbDmEkGMXlFOpVS3Xr hGAzh89HGAOEDzQJjJy9hVDQY4frxKT4L3qYqsaW1y5YtiYVCcKsal490 mTOY0Mo6mYomUlHLJYa/O7l6kxXFAofh43LPr7Zz+IYwdHD71O3V27e0z deQ2qVbTGZri9IOkJDI3Od+W6+nagTRB/tBynwSrxonHKAGrP5CgMz6zq Q==; X-CSE-ConnectionGUID: KorZrEEnSoibzwNJeboyaw== X-CSE-MsgGUID: bGfXjoDWQZKXKgnqL4WiFA== X-IronPort-AV: E=McAfee;i="6800,10657,11852"; a="89064749" X-IronPort-AV: E=Sophos;i="6.25,175,1779174000"; d="scan'208";a="89064749" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2026 13:22:10 -0700 X-CSE-ConnectionGUID: P5V/xKznRAuCLDjx+bPq5g== X-CSE-MsgGUID: tQvVKIaUQxi9ASz+kTZxqg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,175,1779174000"; d="scan'208";a="287613760" Received: from oodele-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.65.76]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2026 13:22:10 -0700 Date: Mon, 20 Jul 2026 13:22:09 -0700 Message-ID: <87fr1dxvgu.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH 3/4] tests/intel/xe_oa: Enable capture just prior to reading OA data In-Reply-To: <20260717210027.2008255-9-umesh.nerlige.ramappa@intel.com> References: <20260717210027.2008255-6-umesh.nerlige.ramappa@intel.com> <20260717210027.2008255-9-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 17 Jul 2026 14:00:31 -0700, Umesh Nerlige Ramappa wrote: > > When running the test in a loop, sometimes the buffer overflow error was > seen with smaller buffer sizes. > To make the non-zero-reason test more robust, enable capture just before > reading the data and surround the read with the load helper calls. Hmm, not sure why this patch should make a difference... Anyway, since you seem to be saying it does, and because it is mostly equivalent to previous code, this is: Reviewed-by: Ashutosh Dixit > > Signed-off-by: Umesh Nerlige Ramappa > --- > tests/intel/xe_oa.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 98f00d377a86..4f652b187bae 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -2678,6 +2678,7 @@ test_non_zero_reason(const struct drm_xe_oa_unit *oau, size_t oa_buffer_size) > DRM_XE_OA_PROPERTY_OA_METRIC_SET, test_set->perf_oa_metrics_set, > DRM_XE_OA_PROPERTY_OA_FORMAT, __ff(fmt), > DRM_XE_OA_PROPERTY_OA_PERIOD_EXPONENT, oa_exponent, > + DRM_XE_OA_PROPERTY_OA_DISABLED, true, > DRM_XE_OA_PROPERTY_OA_BUFFER_SIZE, oa_buffer_size ?: buffer_fill_size > }; > struct intel_xe_oa_open_prop param = { > @@ -2705,16 +2706,16 @@ test_non_zero_reason(const struct drm_xe_oa_unit *oau, size_t oa_buffer_size) > igt_assert(buf); > > igt_debug("Ready to read about %u bytes\n", buf_size); > - > - load_helper_init(); > - load_helper_run(HIGH); > - > if (!oa_buffer_size) > param.num_properties = param.num_properties - 1; > > stream_fd = __perf_open(drm_fd, ¶m, true /* prevent_pm */); > set_fd_flags(stream_fd, O_CLOEXEC); > > + load_helper_init(); > + load_helper_run(HIGH); > + > + do_ioctl(stream_fd, DRM_XE_OBSERVATION_IOCTL_ENABLE, 0); > while (total_len < buf_size && > ((len = read(stream_fd, &buf[total_len], buf_size - total_len)) > 0 || > (len == -1 && (errno == EINTR || errno == EIO)))) { > -- > 2.51.0 >