From: Thomas Gleixner <tglx@kernel.org>
To: Alexander Wilhelm <alexander.wilhelm@westermo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 2/2] irqchip/ls-scfg-msi: enable multi-MSI allocation
Date: Mon, 20 Jul 2026 11:41:48 +0200 [thread overview]
Message-ID: <87fr1engkj.ffs@fw13> (raw)
In-Reply-To: <20260716-irqchip-ls-scfg-msi-add-multi-msi-support-v1-2-9795356d0ebc@westermo.com>
On Thu, Jul 16 2026 at 12:15, Alexander Wilhelm wrote:
> Add MSI_FLAG_MULTI_PCI_MSI to the parent domain's supported flags so PCI
> devices can request more than one contiguous MSI vector. The previous
> refactor to bitmap_find_free_region() already handles arbitrary
> power-of-two orders, so drop the WARN_ON(nr_irqs != 1) guard.
Same comment vs. changelog as before.
> In practice, multi-MSI requires the 'no-affinity' MSIR routing, because
> affinity mode only releases every (1 << ibs_shift)-th hwirq and therefore
> cannot satisfy aligned power-of-two blocks larger than one bit. Statically
> pin each MSIR's chained parent IRQ to its matching CPU in that mode: the
> low ibs_shift bits of the hwirq then select both the MSIR and the target
> CPU, giving each MSI vector a deterministic target CPU without runtime
> migration.
> + } else {
> msir->srs = index;
> + /* Statically pin each MSIR to its matching CPU */
This wants some explanation of the WHY in the comment.
> + if (index < num_possible_cpus())
> + irq_set_affinity(msir->gic_irq, get_cpu_mask(index));
> + }
Thanks,
tglx
prev parent reply other threads:[~2026-07-20 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 10:14 [PATCH RFC 0/2] irqchip/ls-scfg-msi: add multi-MSI support Alexander Wilhelm
2026-07-16 10:15 ` [PATCH RFC 1/2] irqchip/ls-scfg-msi: refactor allocation to bitmap_find_free_region() Alexander Wilhelm
2026-07-20 9:34 ` Thomas Gleixner
2026-07-16 10:15 ` [PATCH RFC 2/2] irqchip/ls-scfg-msi: enable multi-MSI allocation Alexander Wilhelm
2026-07-20 9:41 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fr1engkj.ffs@fw13 \
--to=tglx@kernel.org \
--cc=alexander.wilhelm@westermo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.