All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v2 2/4] drm/xe/oa: Fix offset alignment for MERT WHITELIST_OA_MERT_MMIO_TRG
Date: Mon, 29 Jun 2026 09:27:17 -0700	[thread overview]
Message-ID: <87fr25jore.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <aj21Z9pO9JoXvRVi@soc-5CG1426VCC.clients.intel.com>

On Thu, 25 Jun 2026 16:10:31 -0700, Umesh Nerlige Ramappa wrote:
>
> On Tue, Jun 16, 2026 at 06:54:20PM -0700, Ashutosh Dixit wrote:
> > 'tail_buf' argument for WHITELIST_OA_MERT_MMIO_TRG was previously
> > wrong (not multiple of 16). Fix this.
> >
> > Fixes: ec02e49f21bc ("drm/xe/rtp: Whitelist OAMERT MMIO trigger registers")
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> Note that the SW whitelist needs to be documented in the relevant spec
> sections here: BSpec 53688. Can you please have something to track that?

Sure I will do this.

> With that this is:
>
> Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Thanks!

>
> > ---
> > drivers/gpu/drm/xe/xe_reg_whitelist.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_reg_whitelist.c b/drivers/gpu/drm/xe/xe_reg_whitelist.c
> > index a17ebacc1455b..880079473c26b 100644
> > --- a/drivers/gpu/drm/xe/xe_reg_whitelist.c
> > +++ b/drivers/gpu/drm/xe/xe_reg_whitelist.c
> > @@ -124,7 +124,7 @@ static const struct xe_rtp_table_sr register_whitelist = XE_RTP_TABLE_SR(
> >			      OAM_HEAD_POINTER(XE_OAM_SCMI_1_BASE_ADJ))
> >
> > #define WHITELIST_OA_MERT_MMIO_TRG \
> > -	WHITELIST_OA_MMIO_TRG(OAMERT_MMIO_TRG, OAMERT_STATUS, OAMERT_HEAD_POINTER)
> > +	WHITELIST_OA_MMIO_TRG(OAMERT_MMIO_TRG, OAMERT_STATUS, OAMERT_TAIL_POINTER)
> >
> >	{ XE_RTP_NAME("oag_mmio_trg_rcs"),
> >	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, XE_RTP_END_VERSION_UNDEFINED),
> > --
> > 2.54.0
> >

  reply	other threads:[~2026-06-29 16:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17  1:54 [PATCH v2 0/4] drm/xe/oa: A MERTOA bug-fix Ashutosh Dixit
2026-06-17  1:54 ` [PATCH v2 1/4] drm/xe/oa: Rename last argument of WHITELIST_OA_MMIO_TRG Ashutosh Dixit
2026-06-25 23:06   ` Umesh Nerlige Ramappa
2026-06-29 16:33     ` Dixit, Ashutosh
2026-06-26 16:39   ` Matt Roper
2026-06-29 16:25     ` Dixit, Ashutosh
2026-06-30 23:18       ` Matt Roper
2026-06-17  1:54 ` [PATCH v2 2/4] drm/xe/oa: Fix offset alignment for MERT WHITELIST_OA_MERT_MMIO_TRG Ashutosh Dixit
2026-06-25 23:10   ` Umesh Nerlige Ramappa
2026-06-29 16:27     ` Dixit, Ashutosh [this message]
2026-06-29 17:30       ` Dixit, Ashutosh
2026-06-17  1:54 ` [PATCH v2 3/4] drm/xe/oa: Provide OA status through status ioctl for mmap interface Ashutosh Dixit
2026-06-25 23:16   ` Umesh Nerlige Ramappa
2026-06-26 22:39     ` Dixit, Ashutosh
2026-06-17  1:54 ` [PATCH v2 4/4] drm/xe/oa: Stop whitelisting OA status register Ashutosh Dixit
2026-06-25 23:12   ` Umesh Nerlige Ramappa
2026-06-17  1:59 ` ✗ CI.checkpatch: warning for drm/xe/oa: A MERTOA bug-fix (rev2) Patchwork
2026-06-17  2:01 ` ✓ CI.KUnit: success " Patchwork
2026-06-17  2:38 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-17  8:23 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fr25jore.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.