From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0A2A30EF94 for ; Wed, 17 Jun 2026 19:12:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781723563; cv=none; b=lh2r6notqROKw5UeC/dR9BIzjMK4X7isAwvjnCDorMTRIzDb/RgVkTm+b7ZT7phJB3lEajLb/erFIneAS+DRjbQHDpLkcMzgx5ROOUdOVTEV6qPHBRI4T1YbTHOknUFVEw+gwVgW/G2gBAtx9nnkDXHF4LSbzBK0i2GOfyc7qLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781723563; c=relaxed/simple; bh=/8wLLXm0qnz9Lr1IShIyq73/a/pLN7n6I3Rlcg/Dq8w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=FbZAo8U5ICrbib0kr9u0x/9USkRnxQBd3/+GI4XKfzeWL8ukhaJQqhxCmo17M1km8Trbi+a73BcAJRtTE44A49b9HP2fovfaHBkCFLiIpYvGqZsNUEiXEXmvEMQzL8xJpdAHCnd8W6wt3d8NKF2F77Jr5zSUNPWvCklpkM/hGt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ksc7gTUM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ksc7gTUM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE1431F000E9; Wed, 17 Jun 2026 19:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781723562; bh=mWGPkK88aYeRvUttq27puBIRGSQJ867dDxfEm1jYkNo=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=Ksc7gTUMbZ+2WJblBQaqFR7inufF8PbC5+xh4GEcw7RYXcMPU667BIP3Enkirc2Bc up7HMQbH5OV660GwflJLvbTVzrIUQcvm+PduwPmpZj+/0+2kBt9qgx6jdCTCH56AH/ Aa8VmGCTR2O1tju1P9eUaP0+nlAg4p3wTw1KXS0BGolCvTdpWQKoQJubYcgflqfF90 zMRhd6BmKNjEQocVGc+glNKz+wEGKZbNIeiJgLQBnAlUSGDl9cKqr3a2TOeq3ORdTz 8f/wcPJcagCrN83QPQzHEe1NKnumKbCW9PdxF9ErtCm22M807mIz8ULlM5VNOzOLi3 0E4GfB80Ng9uA== From: Thomas Gleixner To: Bhargav Joshi , Tony Lindgren , Jason Cooper , Marc Zyngier Cc: linux-kernel@vger.kernel.org, goledhruva@gmail.com, m-chawdhry@ti.com, daniel.baluta@gmail.com, simona.toaca@nxp.com, j.bhargav.u@gmail.com Subject: Re: [PATCH 2/2] irqchip: crossbar: Fix parent domain resource leak In-Reply-To: <20260610-irq-crossbar-fix-v1-2-26797369ff6a@gmail.com> References: <20260610-irq-crossbar-fix-v1-0-26797369ff6a@gmail.com> <20260610-irq-crossbar-fix-v1-2-26797369ff6a@gmail.com> Date: Wed, 17 Jun 2026 21:12:39 +0200 Message-ID: <87fr2lc76g.ffs@fw13> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Jun 10 2026 at 02:26, Bhargav Joshi wrote: irqchip/crossbar: .... > irq_domain_alloc_irqs_parent() is called in allocate_gic_irq() but > irq_domain_free_irqs_parent() is never called. causing resource leak. "causing resource leak." is not a a sentence. > Fix this by calling irq_domain_free_irqs_parent() in > crossbar_domain_free(). > > Fixes: 783d31863fb82 ("irqchip: crossbar: Convert dra7 crossbar to stacked domains") > No newline. > Signed-off-by: Bhargav Joshi > --- > drivers/irqchip/irq-crossbar.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c > index 6a4718be0c58..445c925b9c3d 100644 > --- a/drivers/irqchip/irq-crossbar.c > +++ b/drivers/irqchip/irq-crossbar.c > @@ -163,6 +163,7 @@ static void crossbar_domain_free(struct irq_domain *domain, unsigned int virq, > irq_domain_reset_irq_data(d); > } > raw_spin_unlock(&cb->lock); > + irq_domain_free_irqs_parent(domain, virq, nr_irqs); > } > > static int crossbar_domain_translate(struct irq_domain *d,