From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C84ADFED2E4 for ; Thu, 12 Mar 2026 08:11:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w0b84-0005gX-UK; Thu, 12 Mar 2026 04:10:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0b81-0005g3-2e for qemu-devel@nongnu.org; Thu, 12 Mar 2026 04:10:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0b7z-00068q-FT for qemu-devel@nongnu.org; Thu, 12 Mar 2026 04:10:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773303042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LVRw3YvK03Buihz4biFFMmgZQbTNhjwsY2z1vc9Cse8=; b=Stii9Bh/+CRLI3NWeCFV3w5r1JIdU4aQbrtpPsPzGROkiapO+aEaN/PRtr1VEM5HwXJ/Cs RpcmJfClQws3zRlgOty2xEU/w+MyLHPHmHJdFy16dsWlxLft+PRvlMwC0uEAsluiT3QHQs TE/lHFQUd13D6Ra2Rj3/1nofHM1mRHo= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-577-tvbG_LrhPISOd_eQrVapeg-1; Thu, 12 Mar 2026 04:10:39 -0400 X-MC-Unique: tvbG_LrhPISOd_eQrVapeg-1 X-Mimecast-MFC-AGG-ID: tvbG_LrhPISOd_eQrVapeg_1773303038 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED88C195609F; Thu, 12 Mar 2026 08:10:37 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.12]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9351D19540C2; Thu, 12 Mar 2026 08:10:37 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 2B0DB21E681B; Thu, 12 Mar 2026 09:10:35 +0100 (CET) From: Markus Armbruster To: alistair23@gmail.com Cc: qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, berrange@redhat.com, peterx@redhat.com, philmd@linaro.org, Alistair Francis Subject: Re: [PATCH 0/7] Fix some -device T,help crashes In-Reply-To: <20260312043158.4191378-1-alistair.francis@wdc.com> (alistair's message of "Thu, 12 Mar 2026 14:31:51 +1000") References: <20260312043158.4191378-1-alistair.francis@wdc.com> Date: Thu, 12 Mar 2026 09:10:35 +0100 Message-ID: <87fr65zcw4.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org alistair23@gmail.com writes: > From: Alistair Francis > > Markus reported the following > > """ > Watch this: > > $ qemu-system-aarch64 -S -display none -M virt -device acpi-ged,help > qemu-system-aarch64: ../hw/core/qdev.c:858: qdev_get_machine: Assertion `dev' failed. The comment right before the assertion explains: /* * Any call to this function before machine is created is treated * as a programming error as of now. */ i.e. we're talking about straightforward programming errors. > A number of devices crash this way: > > * acpi-ged (aarch64 arm i386 loongarch64 x86_64) > * fsl-imx6 (aarch64 arm) > * fsl-imx7 (aarch64 arm) > * fsl-imx8mp (aarch64) > * microchip.pfsoc (riscv64) > * riscv.sifive.e.soc (riscv32 riscv64) > * xlnx-zynqmp (aarch64) > """ > > This series fixes the crashes Series Tested-by: Markus Armbruster