From: Thomas Gleixner <tglx@kernel.org>
To: Janne Grunau <j@jannau.net>, Sven Peter <sven@kernel.org>,
Neal Gompa <neal@gompa.dev>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Janne Grunau <j@jannau.net>
Subject: Re: [PATCH 2/2] irqchip/apple-aic: Add support for "apple,t8122-aic3"
Date: Mon, 26 Jan 2026 16:52:06 +0100 [thread overview]
Message-ID: <87fr7scqxl.ffs@tglx> (raw)
In-Reply-To: <20260125-irq-apple-aic3-v1-2-a2afe66a6ab9@jannau.net>
On Sun, Jan 25 2026 at 12:08, Janne Grunau wrote:
> +/*
> + * AIC v3 registers (MMIO)
> + */
> +
Pointless newline and please make this a /* Oneline comment */
> +#define AIC3_IRQ_CFG 0x10000
> +
> }
> + case 3:
> case 2: {
1 3 2 is a weird count order...
Thanks,
tglx
next prev parent reply other threads:[~2026-01-26 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-25 11:08 [PATCH 0/2] Add Apple interrupt controller 3 support Janne Grunau
2026-01-25 11:08 ` [PATCH 1/2] dt-bindings: interrupt-controller: apple,aic2: Add AICv3 Janne Grunau
2026-01-25 11:35 ` Mark Kettenis
2026-01-25 11:48 ` Janne Grunau
2026-01-25 11:08 ` [PATCH 2/2] irqchip/apple-aic: Add support for "apple,t8122-aic3" Janne Grunau
2026-01-25 11:42 ` Sven Peter
2026-01-25 11:59 ` Janne Grunau
2026-01-26 15:52 ` Thomas Gleixner [this message]
2026-01-28 8:29 ` Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fr7scqxl.ffs@tglx \
--to=tglx@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal@gompa.dev \
--cc=robh@kernel.org \
--cc=sven@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.