From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4C69D74EC2 for ; Fri, 23 Jan 2026 13:51:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vjHVr-0008Fu-QG; Fri, 23 Jan 2026 08:47:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjHVO-000831-8C for qemu-devel@nongnu.org; Fri, 23 Jan 2026 08:47:19 -0500 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vjHVL-0006Pd-NF for qemu-devel@nongnu.org; Fri, 23 Jan 2026 08:47:17 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2A7205BCD4; Fri, 23 Jan 2026 13:47:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769176034; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fpQyTot+iGrCpH+hAwj3szmCIHQDUXGMYIt6z3is4Q4=; b=fVC+D1FY7T25rlEyGtxjZVQsLTU1HZYxWbsu9Y91mlVtbih8NJW2VQEG30ryQm/s8bVaef G0czBmVngQm+wdMucEF0LNrRrNrO57OURUDNt3YDDin9W6fqFmrnSopgzoXM/immkLgRvK BUvB+jwrI2JQY8fiO9zS5LuUfN0dp7Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769176034; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fpQyTot+iGrCpH+hAwj3szmCIHQDUXGMYIt6z3is4Q4=; b=+/refVIdxiqPmmaxYmW9IAyOdkDVW9ZU3G1dTray2Wd/torEA3q9AqsNuQqHC1SmbMjSEz G5+yDwzUz03lsJDQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fVC+D1FY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="+/refVId" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769176034; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fpQyTot+iGrCpH+hAwj3szmCIHQDUXGMYIt6z3is4Q4=; b=fVC+D1FY7T25rlEyGtxjZVQsLTU1HZYxWbsu9Y91mlVtbih8NJW2VQEG30ryQm/s8bVaef G0czBmVngQm+wdMucEF0LNrRrNrO57OURUDNt3YDDin9W6fqFmrnSopgzoXM/immkLgRvK BUvB+jwrI2JQY8fiO9zS5LuUfN0dp7Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769176034; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fpQyTot+iGrCpH+hAwj3szmCIHQDUXGMYIt6z3is4Q4=; b=+/refVIdxiqPmmaxYmW9IAyOdkDVW9ZU3G1dTray2Wd/torEA3q9AqsNuQqHC1SmbMjSEz G5+yDwzUz03lsJDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 914121395E; Fri, 23 Jan 2026 13:47:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8zUiFOF7c2mlfQAAD6G6ig (envelope-from ); Fri, 23 Jan 2026 13:47:13 +0000 From: Fabiano Rosas To: Peter Xu , qemu-devel@nongnu.org Cc: Prasad Pandit , Lukas Straub , Juraj Marcin , peterx@redhat.com Subject: Re: [PATCH 04/10] migration/savevm: Remove SaveStateEntry.is_ram In-Reply-To: <20260121223336.3381912-5-peterx@redhat.com> References: <20260121223336.3381912-1-peterx@redhat.com> <20260121223336.3381912-5-peterx@redhat.com> Date: Fri, 23 Jan 2026 10:47:10 -0300 Message-ID: <87fr7wigpt.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[web.de]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_TWO(0.00)[2]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[redhat.com,web.de]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+]; MISSING_XM_UA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo, suse.de:dkim, suse.de:mid] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 2A7205BCD4 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > It's neither accurate nor necessary. Use a proper helper to detect if it's > an iterable savevm state entry instead. Could you explain what exactly is_ram was supposed to mean? > > Signed-off-by: Peter Xu > --- > migration/savevm.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/migration/savevm.c b/migration/savevm.c > index 61e873d90c..f1cd8c913d 100644 > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -249,7 +249,6 @@ typedef struct SaveStateEntry { > const VMStateDescription *vmsd; > void *opaque; > CompatEntry *compat; > - int is_ram; > } SaveStateEntry; > > typedef struct SaveState { > @@ -816,10 +815,6 @@ int register_savevm_live(const char *idstr, > se->ops = ops; > se->opaque = opaque; > se->vmsd = NULL; > - /* if this is a live_savem then set is_ram */ > - if (ops->save_setup != NULL) { > - se->is_ram = 1; > - } > > pstrcat(se->idstr, sizeof(se->idstr), idstr); > > @@ -1866,6 +1861,12 @@ void qemu_savevm_live_state(QEMUFile *f) > qemu_put_byte(f, QEMU_VM_EOF); > } > > +/* Is a save state entry iterable (e.g. RAM)? */ > +static bool qemu_savevm_se_iterable(SaveStateEntry *se) > +{ > + return se->ops && se->ops->save_setup; So it could be iterable and not have .save_live_iterate? Also, what's the deal with slirp? AIUI, it would be considered is_ram? > +} > + > int qemu_save_device_state(QEMUFile *f) > { > Error *local_err = NULL; > @@ -1876,7 +1877,7 @@ int qemu_save_device_state(QEMUFile *f) > QTAILQ_FOREACH(se, &savevm_state.handlers, entry) { > int ret; > > - if (se->is_ram) { > + if (qemu_savevm_se_iterable(se)) { Hmm, qemu_savevm_state_setup has: if (!se->ops || !se->ops->save_setup) { continue; } therefore: if (!qemu_savevm_se_iterable(se)) { continue; } Maybe it would be more practical to put these in a separate list already while registering. > continue; > } > ret = vmstate_save(f, se, NULL, &local_err); > @@ -2648,7 +2649,7 @@ qemu_loadvm_section_start_full(QEMUFile *f, uint8_t type, Error **errp) > se->load_section_id = section_id; > > /* Validate if it is a device's state */ > - if (xen_enabled() && se->is_ram) { > + if (xen_enabled() && qemu_savevm_se_iterable(se)) { > error_setg(errp, "loadvm: %s RAM loading not allowed on Xen", idstr); > return -EINVAL; > }