All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org,  Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH 1/3] docs/system/generic-loader: Clarify behaviour of cpu-num
Date: Tue, 25 Nov 2025 14:54:10 +0000	[thread overview]
Message-ID: <87fra26u3x.fsf@draig.linaro.org> (raw)
In-Reply-To: <20251125143141.216056-2-peter.maydell@linaro.org> (Peter Maydell's message of "Tue, 25 Nov 2025 14:31:39 +0000")

Peter Maydell <peter.maydell@linaro.org> writes:

> The cpu-num suboption to the generic loader has two effects when
> it is used with -device loader,file=<file>:
>  * it specifies which CPU to load the data through
>  * it specifies which CPU gets its PC set to the file's entry point
>
> Our documentation is not very clear about what happens if you don't
> pass this suboption.  The default is that we pick the first CPU to
> load the data, but we don't set the PC for any CPU, so the "If not
> specified, the default is CPU 0" is confusing: it applies for loading
> but not for the PC setting.
>
> Clarify the text to make it clearer that the option has two effects
> and the default behaviour is different for the two effects.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


  reply	other threads:[~2025-11-25 14:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25 14:31 [PATCH 0/3] generic-loader: improve docs Peter Maydell
2025-11-25 14:31 ` [PATCH 1/3] docs/system/generic-loader: Clarify behaviour of cpu-num Peter Maydell
2025-11-25 14:54   ` Alex Bennée [this message]
2025-11-25 14:31 ` [PATCH 2/3] docs/system/generic-loader: Don't mention QemuOpts implementation detail Peter Maydell
2025-11-25 14:56   ` Alex Bennée
2025-11-25 15:00     ` Peter Maydell
2025-11-25 14:31 ` [PATCH 3/3] docs/system/generic-loader: move TODO to source code Peter Maydell
2025-11-25 14:57   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fra26u3x.fsf@draig.linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=alistair@alistair23.me \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.