From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: pengdonglin <dolinux.peng@gmail.com>,
tj@kernel.org, tony.luck@intel.com, jani.nikula@linux.intel.com,
ap420073@gmail.com, jv@jvosburgh.net, freude@linux.ibm.com,
bcrl@kvack.org, trondmy@kernel.org, longman@redhat.com,
kees@kernel.org
Cc: bigeasy@linutronix.de, hdanton@sina.com, paulmck@kernel.org,
linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
linux-nfs@vger.kernel.org, linux-aio@kvack.org,
linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org, netdev@vger.kernel.org,
intel-gfx@lists.freedesktop.org, linux-wireless@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org,
cgroups@vger.kernel.org, pengdonglin <dolinux.peng@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
pengdonglin <pengdonglin@xiaomi.com>
Subject: Re: [PATCH v3 14/14] wifi: ath9k: Remove redundant rcu_read_lock/unlock() in spin_lock
Date: Mon, 17 Nov 2025 12:47:07 +0100 [thread overview]
Message-ID: <87fracop8k.fsf@toke.dk> (raw)
In-Reply-To: <20250916044735.2316171-15-dolinux.peng@gmail.com>
pengdonglin <dolinux.peng@gmail.com> writes:
> From: pengdonglin <pengdonglin@xiaomi.com>
>
> Since commit a8bb74acd8efe ("rcu: Consolidate RCU-sched update-side function definitions")
> there is no difference between rcu_read_lock(), rcu_read_lock_bh() and
> rcu_read_lock_sched() in terms of RCU read section and the relevant grace
> period. That means that spin_lock(), which implies rcu_read_lock_sched(),
> also implies rcu_read_lock().
>
> There is no need no explicitly start a RCU read section if one has already
> been started implicitly by spin_lock().
>
> Simplify the code and remove the inner rcu_read_lock() invocation.
>
> Cc: "Toke" <toke@toke.dk>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: pengdonglin <pengdonglin@xiaomi.com>
> Signed-off-by: pengdonglin <dolinux.peng@gmail.com>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
next prev parent reply other threads:[~2025-11-17 11:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 4:47 [PATCH v3 00/14] Remove redundant rcu_read_lock/unlock() in spin_lock pengdonglin
2025-09-16 4:47 ` [PATCH v3 01/14] ACPI: APEI: " pengdonglin
2025-09-27 3:22 ` Hanjun Guo
2025-09-28 10:33 ` Rafael J. Wysocki
2025-09-16 4:47 ` [PATCH v3 02/14] drm/i915/gt: " pengdonglin
2025-09-16 4:47 ` [PATCH v3 03/14] fs: aio: " pengdonglin
2025-09-16 4:47 ` [PATCH v3 04/14] nfs: " pengdonglin
2025-09-16 4:47 ` [PATCH v3 05/14] s390/pkey: " pengdonglin
2025-09-16 10:51 ` Harald Freudenberger
2025-09-16 4:47 ` [PATCH v3 06/14] ipc: " pengdonglin
2025-09-16 4:47 ` [PATCH v3 07/14] yama: " pengdonglin
2025-09-16 4:47 ` [PATCH v3 08/14] cgroup: " pengdonglin
2025-09-16 18:37 ` Tejun Heo
2025-09-16 4:47 ` [PATCH v3 09/14] cgroup/cpuset: " pengdonglin
2025-09-16 18:37 ` Tejun Heo
2025-09-16 4:47 ` [PATCH v3 10/14] wifi: mac80211: " pengdonglin
2025-09-16 4:47 ` [PATCH v3 11/14] net: ncsi: " pengdonglin
2025-09-16 9:41 ` Paul Fertser
2025-09-16 4:47 ` [PATCH v3 12/14] net: amt: " pengdonglin
2025-09-16 4:47 ` [PATCH v3 13/14] net: bonding: " pengdonglin
2025-09-16 4:47 ` [PATCH v3 14/14] wifi: ath9k: " pengdonglin
2025-11-17 11:47 ` Toke Høiland-Jørgensen [this message]
2025-09-16 16:09 ` ✗ LGCI.VerificationFailed: failure for " Patchwork
2025-11-18 7:24 ` [PATCH v3 00/14] " Sebastian Andrzej Siewior
2026-04-30 21:30 ` (subset) " Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fracop8k.fsf@toke.dk \
--to=toke@toke.dk \
--cc=ap420073@gmail.com \
--cc=bcrl@kvack.org \
--cc=bigeasy@linutronix.de \
--cc=cgroups@vger.kernel.org \
--cc=dolinux.peng@gmail.com \
--cc=freude@linux.ibm.com \
--cc=hdanton@sina.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jv@jvosburgh.net \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=linux-s390@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=longman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=pengdonglin@xiaomi.com \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.