From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Mattijs Korpershoek <mkorpershoek@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Khairul Anuar Romli <khairul.anuar.romli@altera.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: cadence-quadspi: Fix pm_runtime unbalance on dma EPROBE_DEFER
Date: Thu, 09 Oct 2025 09:09:07 +0200 [thread overview]
Message-ID: <87frbswnzg.fsf@kernel.org> (raw)
In-Reply-To: <aOaEZmrWgy_g0u7c@stanley.mountain>
Hi Dan,
Thank you for the review.
On Wed, Oct 08, 2025 at 18:33, Dan Carpenter <dan.carpenter@linaro.org> wrote:
> On Wed, Oct 08, 2025 at 03:38:39PM +0200, Mattijs Korpershoek wrote:
>> In csqspi_probe(), when cqspi_request_mmap_dma() returns -EPROBE_DEFER,
>> we handle the error by jumping to probe_setup_failed.
>> In that label, we call pm_runtime_disable(), even if we never called
>> pm_runtime_enable() before.
>>
>> Because of this, the driver cannot probe:
>>
>> [ 2.690018] cadence-qspi 47040000.spi: No Rx DMA available
>> [ 2.699735] spi-nor spi0.0: resume failed with -13
>> [ 2.699741] spi-nor: probe of spi0.0 failed with error -13
>>
>> Only call pm_runtime_disable() if it was enabled by adding a new
>> label to handle cqspi_request_mmap_dma() failures.
>>
>> Fixes: 04a8ff1bc351 ("spi: cadence-quadspi: fix cleanup of rx_chan on failure paths")
>> Signed-off-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
>> ---
>> This has been tested on a AM69 SK board.
>
> The patch seems correct, but the correct Fixes tag is:
> Fixes: b07f349d1864 ("spi: spi-cadence-quadspi: Fix pm runtime unbalance")
Right, I hesitated between the 04a8ff1bc351 and b07f349d1864. I will
send a v2 with an updated Fixes tag.
>
> regards,
> dan carpenter
prev parent reply other threads:[~2025-10-09 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 13:38 [PATCH] spi: cadence-quadspi: Fix pm_runtime unbalance on dma EPROBE_DEFER Mattijs Korpershoek
2025-10-08 15:33 ` Dan Carpenter
2025-10-09 7:09 ` Mattijs Korpershoek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frbswnzg.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=khairul.anuar.romli@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.