All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charalampos Mitrodimas <charmitro@posteo.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Greg KH <greg@kroah.com>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	 Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the tty tree
Date: Wed, 01 Oct 2025 00:00:04 +0000	[thread overview]
Message-ID: <87frc3sd8d.fsf@posteo.net> (raw)
In-Reply-To: <20250729151404.03ac580e@canb.auug.org.au>

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> After merging the tty tree, today's linux-next build (x86_64
> modules_install) failed like this:
>
> depmod: ERROR: Cycle detected: 8250 -> 8250_base -> 8250
> depmod: ERROR: Found 2 modules in dependency cycles!

The cycle was introduced by commit

  b20d6576cdb3 ("serial: 8250: export RSA functions")

which exported RSA functions from 8250.ko to 8250_base.ko to fix this
issue:

  ERROR: modpost: "rsa_autoconfig" [drivers/tty/serial/8250/8250_base.ko] undefined!
  ERROR: modpost: "rsa_reset" [drivers/tty/serial/8250/8250_base.ko] undefined!
  ERROR: modpost: "rsa_disable" [drivers/tty/serial/8250/8250_base.ko] undefined!
  ERROR: modpost: "rsa_enable" [drivers/tty/serial/8250/8250_base.ko] undefined!

which was a regression introduced in this patchset[1].

Before this patchset there's no issue at all:

  INSTALL /tmp/test_cycle/lib/modules/6.16.0-rc2/kernel/drivers/tty/serial/8250/8250.ko
  INSTALL /tmp/test_cycle/lib/modules/6.16.0-rc2/kernel/drivers/tty/serial/8250/8250_base.ko
  INSTALL /tmp/test_cycle/lib/modules/6.16.0-rc2/kernel/drivers/tty/serial/8250/8250_exar.ko
  INSTALL /tmp/test_cycle/lib/modules/6.16.0-rc2/kernel/drivers/tty/serial/8250/8250_lpss.ko
  INSTALL /tmp/test_cycle/lib/modules/6.16.0-rc2/kernel/drivers/tty/serial/8250/8250_mid.ko
  INSTALL /tmp/test_cycle/lib/modules/6.16.0-rc2/kernel/drivers/tty/serial/8250/8250_pci.ko
  INSTALL /tmp/test_cycle/lib/modules/6.16.0-rc2/kernel/drivers/tty/serial/8250/8250_pericom.ko
  INSTALL /tmp/test_cycle/lib/modules/6.16.0-rc2/kernel/drivers/tty/serial/serial_base.ko

So circular dependency landed in b20d6576cdb3 since 8250_base already
depends on 8250.

I'm guessing the fix would be to merge 8250_base.ko into 8250.ko in
drivers/tty/serial/8250/Makefile?

Stephen, I mistakenly sent this off-list to you, ignore it.

[1]: https://lore.kernel.org/all/20250611100319.186924-1-jirislaby@kernel.org/

>
> I can't see what would have caused this (it actually appeared yesterday).
> I am not even sure it is something in the tty tree.

  reply	other threads:[~2025-10-01  0:00 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29  5:14 linux-next: build failure after merge of the tty tree Stephen Rothwell
2025-10-01  0:00 ` Charalampos Mitrodimas [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-06-19  6:56 Stephen Rothwell
2025-06-19  8:19 ` Greg KH
2025-06-23  6:03   ` Jiri Slaby
2025-03-24  8:37 Stephen Rothwell
2025-03-24  9:10 ` Sherry Sun
2025-03-24 13:27   ` Greg KH
2025-02-06  2:53 Stephen Rothwell
2025-02-06  5:15 ` Greg KH
2025-02-06  7:40 ` Benjamin Larsson
2025-02-06  8:14   ` Greg KH
2025-02-06 23:09     ` Stephen Rothwell
2025-02-09 21:13     ` Benjamin Larsson
2024-04-11  5:48 Stephen Rothwell
2024-04-11  5:59 ` Tony Lindgren
2023-01-23  2:18 Stephen Rothwell
2023-01-23  9:46 ` Bartosz Golaszewski
2023-01-23 17:52   ` Greg KH
2022-08-02 20:06 broonie
2022-08-02 20:27 ` Doug Anderson
2022-08-03  6:10   ` Greg KH
2019-06-13  5:32 Stephen Rothwell
2019-06-13  6:10 ` Greg KH
2018-10-04  5:19 Stephen Rothwell
2018-10-04 16:34 ` Steve Sakoman
2018-10-04 17:00   ` Greg Kroah-Hartman
2018-10-04 17:13     ` Steve Sakoman
2018-10-04 18:13     ` Steve Sakoman
2018-10-04 18:22       ` Greg Kroah-Hartman
2018-09-11  2:58 Stephen Rothwell
2018-09-11  8:23 ` Greg KH
2018-09-11  8:25 ` Lee Jones
2018-09-11  8:32   ` Nicolas Ferre
2018-09-11  8:43     ` Lee Jones
2018-09-18  4:54       ` Andy Shevchenko
2017-12-18  3:28 Stephen Rothwell
2017-12-18  8:52 ` Geert Uytterhoeven
2017-12-18  9:02   ` Greg KH
2017-12-18  9:33     ` Greg KH
2017-02-06  4:22 Stephen Rothwell
2017-02-06  8:51 ` Greg KH
2017-02-06 14:09   ` Rob Herring
2017-02-06 15:18     ` Greg KH
2017-02-06 20:38       ` Stephen Rothwell
2016-09-30  3:54 Stephen Rothwell
2016-09-30  5:46 ` Greg KH
2015-08-18  6:01 Stephen Rothwell
2015-08-18 16:12 ` Greg KH
2015-05-11  5:16 Stephen Rothwell
2015-05-11 10:42 ` Dave Martin
2014-09-30  7:39 Stephen Rothwell
2014-09-30  7:52 ` Sebastian Andrzej Siewior
2014-09-30  8:09   ` Stephen Rothwell
2014-09-25  6:30 Stephen Rothwell
2014-09-25 11:04 ` Greg KH
2014-05-29  7:28 Stephen Rothwell
     [not found] ` <5EB3BFCD089AD643B9BB63439F5FD5E9012BF05ED1@SHAASIEXM01.ASIA.ROOT.PRI>
2014-05-29 12:29   ` Barry Song
2013-10-31  7:40 Stephen Rothwell
2013-10-31 10:35 ` Sedat Dilek
2013-10-31 13:09   ` Philippe Proulx
2013-10-31 13:24     ` Greg KH
2013-07-24  4:42 Stephen Rothwell
2013-07-24 13:29 ` Peter Hurley
2013-05-21  3:25 Stephen Rothwell
2013-03-20  3:12 Stephen Rothwell
2013-03-20  8:17 ` Jiri Slaby
2013-03-20 12:51   ` Bill Pemberton
2013-03-20 12:51     ` Bill Pemberton
2013-03-20 14:17     ` Jiri Slaby
2013-03-20 14:42       ` Bill Pemberton
2013-03-20 14:42         ` Bill Pemberton
2013-03-20 15:13         ` Jiri Slaby
2013-03-20 15:15           ` Bill Pemberton
2013-03-20 15:15             ` Bill Pemberton
2013-03-21  0:16             ` Greg KH
2013-03-21 22:54               ` Stephen Rothwell
2013-03-21 23:28                 ` Stephen Rothwell
2013-03-21 23:47                   ` Greg KH
2013-03-22  0:42                     ` Stephen Rothwell
2013-03-21 23:36                 ` Greg KH
2013-03-21  4:20 ` Stephen Rothwell
2012-10-24  2:28 Stephen Rothwell
2012-10-24  2:51 ` Greg KH
2012-09-06  5:10 Stephen Rothwell
2012-09-06 11:47 ` Alan Cox
2012-07-20  3:33 Stephen Rothwell
2012-07-25 22:51 ` Stephen Rothwell
2012-07-26  0:25   ` Alan Cox
2012-07-20  3:28 Stephen Rothwell
2012-07-25 22:47 ` Greg KH
2012-07-25 22:49 ` Stephen Rothwell
2012-07-19  4:36 Stephen Rothwell
2012-07-19 10:41 ` Alan Cox
2012-07-17  3:45 Stephen Rothwell
2012-07-17 10:10 ` Alan Cox
2012-07-17 15:45   ` Greg KH
2012-07-17 15:45 ` Greg KH
2012-07-17 16:05   ` Alan Cox
2012-07-13  4:13 Stephen Rothwell
2012-07-13 11:10 ` Alan Cox
2012-07-20 18:38   ` Geert Uytterhoeven
2012-07-20 20:55     ` Alan Cox
2012-07-20 21:06       ` Geert Uytterhoeven
2012-04-10  3:06 Stephen Rothwell
2011-08-24  4:33 Stephen Rothwell
2011-08-24  4:50 ` Greg KH
2011-08-24  4:50   ` Greg KH
2011-02-24  5:40 Stephen Rothwell
2011-02-25 17:54 ` Greg KH
2010-09-23  4:20 Stephen Rothwell
2010-09-23 14:14 ` Greg KH
2010-09-23 15:13   ` Randy Dunlap
2010-09-23 15:46     ` Alan Cox
2010-09-23 17:12     ` Alan Cox
2010-09-23 17:13       ` Randy Dunlap
2010-07-27  5:18 Stephen Rothwell
2010-07-27  7:43 ` Alan Cox
2010-07-27 16:47   ` Greg KH
2010-07-28  1:19     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frc3sd8d.fsf@posteo.net \
    --to=charmitro@posteo.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.