From: Thomas Gleixner <tglx@linutronix.de>
To: Marc Zyngier <maz@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
James Clark <james.clark@linaro.org>
Subject: Re: [PATCH 01/25] irqdomain: Add firmware info reporting interface
Date: Tue, 09 Sep 2025 11:24:53 +0200 [thread overview]
Message-ID: <87frcwvuze.ffs@tglx> (raw)
In-Reply-To: <87ikhsvvau.ffs@tglx>
On Tue, Sep 09 2025 at 11:18, Thomas Gleixner wrote:
> On Mon, Sep 08 2025 at 17:31, Marc Zyngier wrote:
>> +int irq_populate_fwspec_info(struct irq_fwspec_info *info)
>> +{
>> + struct irq_domain *domain;
>> +
>> + domain = fwspec_to_domain(&info->fwspec);
>
> Just move that to the declaration line
>
>> + if (!domain || !domain->ops->get_info) {
>> + info->flags = 0;
It looks like @info is not initialized except for info::fwspec. That's a
patently bad idea.
Why has fwspec to be in info in the first place? What's wrong with doing
the obvious:
int irq_populate_fwspec_info(struct irq_fwspec *fwspec, struct irq_fwspec_info *info)
{
memset(info, 0, sizeof(info));
....
No?
Thanks,
tglx
next prev parent reply other threads:[~2025-09-09 9:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 16:31 [PATCH 00/25] genirq: Add support for percpu_devid IRQ affinity Marc Zyngier
2025-09-08 16:31 ` [PATCH 01/25] irqdomain: Add firmware info reporting interface Marc Zyngier
2025-09-09 9:18 ` Thomas Gleixner
2025-09-09 9:24 ` Thomas Gleixner [this message]
2025-09-11 14:13 ` Marc Zyngier
2025-09-11 15:49 ` Thomas Gleixner
2025-09-08 16:31 ` [PATCH 02/25] ACPI: irq: Add IRQ affinity " Marc Zyngier
2025-09-08 17:20 ` Rafael J. Wysocki
2025-09-08 16:31 ` [PATCH 03/25] of/irq: " Marc Zyngier
2025-09-08 16:31 ` [PATCH 04/25] platform: Add firmware-agnostic irq and affinity retrieval interface Marc Zyngier
2025-09-08 16:31 ` [PATCH 05/25] irqchip/gic-v3: Add FW info retrieval support Marc Zyngier
2025-09-09 9:37 ` Thomas Gleixner
2025-09-08 16:31 ` [PATCH 06/25] irqchip/apple-aic: " Marc Zyngier
2025-09-08 16:31 ` [PATCH 07/25] coresight: trbe: Convert to new IRQ affinity retrieval API Marc Zyngier
2025-09-08 16:31 ` [PATCH 08/25] perf: arm_pmu: " Marc Zyngier
2025-09-08 16:31 ` [PATCH 09/25] perf: arm_spe_pmu: " Marc Zyngier
2025-09-08 16:31 ` [PATCH 10/25] perf: arm_pmu: Add PMU/CPU affinity tracking Marc Zyngier
2025-09-08 16:31 ` [PATCH 11/25] genirq: Merge irqaction::{dev_id,percpu_dev_id} Marc Zyngier
2025-09-08 16:31 ` [PATCH 12/25] genirq: Factor-in percpu irqaction creation Marc Zyngier
2025-09-09 9:41 ` Thomas Gleixner
2025-09-08 16:31 ` [PATCH 13/25] genirq: Add affinity to percpu_devid interrupt requests Marc Zyngier
2025-09-08 16:31 ` [PATCH 14/25] genirq: Update request_percpu_nmi() to take an affinity Marc Zyngier
2025-09-09 9:45 ` Thomas Gleixner
2025-09-09 11:21 ` Marc Zyngier
2025-09-08 16:31 ` [PATCH 15/25] genirq: Allow per-cpu interrupt sharing for non-overlapping affinities Marc Zyngier
2025-09-10 8:28 ` Marc Zyngier
2025-09-10 14:47 ` Thomas Gleixner
2025-09-10 15:44 ` Marc Zyngier
2025-09-08 16:31 ` [PATCH 16/25] genirq: Add request_percpu_irq_affinity() helper Marc Zyngier
2025-09-08 16:31 ` [PATCH 17/25] perf: arm_pmu: Use a backend-specific pointer for percpu interrupt request Marc Zyngier
2025-09-08 16:31 ` [PATCH 18/25] perf: arm_pmu: Request specific affinities for percpu NMI/IRQ Marc Zyngier
2025-09-08 16:31 ` [PATCH 19/25] perf: arm_spe_pmu: Request specific affinities for percpu IRQ Marc Zyngier
2025-09-08 16:31 ` [PATCH 20/25] coresight: trbe: " Marc Zyngier
2025-09-08 16:31 ` [PATCH 21/25] irqchip/gic-v3: Drop support for custom PPI partitions Marc Zyngier
2025-09-08 16:31 ` [PATCH 22/25] irqchip/apple-aic: Drop support for custom PMU irq partitions Marc Zyngier
2025-09-08 16:31 ` [PATCH 23/25] irqchip: Kill irq-partition-percpu Marc Zyngier
2025-09-08 16:31 ` [PATCH 24/25] genirq: Kill irq_{g,s}et_percpu_devid_partition() Marc Zyngier
2025-09-08 16:31 ` [PATCH 25/25] perf: arm_pmu: Kill last use of per-CPU cpu_armpmu pointer Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frcwvuze.ffs@tglx \
--to=tglx@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=j@jannau.net \
--cc=james.clark@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=suzuki.poulose@arm.com \
--cc=sven@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.