From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Xenomai <xenomai@lists.linux.dev>
Subject: Re: [PATCH dovetail-6.16] generic: irq_pipeline: Fix fallouts of lock guard conversion
Date: Wed, 30 Jul 2025 22:31:44 +0200 [thread overview]
Message-ID: <87frede7yn.fsf@xenomai.org> (raw)
In-Reply-To: <cc22b13d-7324-475c-b060-641a9ec617d0@siemens.com> (Jan Kiszka's message of "Wed, 30 Jul 2025 21:39:44 +0200")
Jan Kiszka <jan.kiszka@siemens.com> writes:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> The irq_chip_generic struct uses a hard_spinlock to support the irq
> pipeline.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> Should unbreak the Xenomai CI pipeline.
>
> drivers/irqchip/irq-bcm7120-l2.c | 2 +-
> drivers/soc/dove/pmu.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-bcm7120-l2.c b/drivers/irqchip/irq-bcm7120-l2.c
> index 28cebe480eb1d..a2f8433d9a564 100644
> --- a/drivers/irqchip/irq-bcm7120-l2.c
> +++ b/drivers/irqchip/irq-bcm7120-l2.c
> @@ -68,7 +68,7 @@ static void bcm7120_l2_intc_irq_handle(struct irq_desc *desc)
> int hwirq;
>
> gc = irq_get_domain_generic_chip(b->domain, base);
> - scoped_guard (raw_spinlock, &gc->lock) {
> + scoped_guard (hard_spinlock, &gc->lock) {
> pending = irq_reg_readl(gc, b->stat_offset[idx]) & gc->mask_cache &
> data->irq_map_mask[idx];
> }
> diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
> index 7bbd3f940e4d9..142ccda535176 100644
> --- a/drivers/soc/dove/pmu.c
> +++ b/drivers/soc/dove/pmu.c
> @@ -257,7 +257,7 @@ static void pmu_irq_handler(struct irq_desc *desc)
> * So, let's structure the code so that the window is as small as
> * possible.
> */
> - guard(raw_spinlock)(&gc->lock);
> + guard(hard_spinlock)(&gc->lock);
> done &= readl_relaxed(base + PMC_IRQ_CAUSE);
> writel_relaxed(done, base + PMC_IRQ_CAUSE);
> }
Merged, thanks.
--
Philippe.
prev parent reply other threads:[~2025-07-30 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 19:39 [PATCH dovetail-6.16] generic: irq_pipeline: Fix fallouts of lock guard conversion Jan Kiszka
2025-07-30 20:31 ` Philippe Gerum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frede7yn.fsf@xenomai.org \
--to=rpm@xenomai.org \
--cc=jan.kiszka@siemens.com \
--cc=xenomai@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.