Re: [PATCH V2 4/5] qom: qom-list-getv

[Markus Armbruster <armbru@redhat.com>]

Steven Sistare <steven.sistare@oracle.com> writes:

> On 7/4/2025 8:22 AM, Markus Armbruster wrote:
>> Steve Sistare <steven.sistare@oracle.com> writes:
>> 
>>> Define the qom-list-getv command, which fetches all the properties and
>>> values for a list of paths.  This is faster than qom-tree-get when
>>> fetching a subset of the QOM tree.  See qom.json for details.
>>>
>>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
>>> ---
>>>   qapi/qom.json      | 34 ++++++++++++++++++++++++++++++++++
>>>   qom/qom-qmp-cmds.c | 40 ++++++++++++++++++++++++++++++++++++++++
>>>   2 files changed, 74 insertions(+)
>>>
>>> diff --git a/qapi/qom.json b/qapi/qom.json
>>> index 94662ad..dc710d6 100644
>>> --- a/qapi/qom.json
>>> +++ b/qapi/qom.json
>>> @@ -62,6 +62,16 @@
>>>               '*value': 'any' } }
>>>   
>>>  ##
>>> +# @ObjectPropertiesValues:
>>> +#
>>> +# @properties: a list of properties.
>>> +#
>>> +# Since 10.1
>>> +##
>>> +{ 'struct': 'ObjectPropertiesValues',
>>> +  'data': { 'properties': [ 'ObjectPropertyValue' ] }}
>>> +
>>> +##
>>>  # @ObjectNode:
>>>  #
>>>  # @name: the name of the node
>>> @@ -158,6 +168,30 @@
>>>     'allow-preconfig': true }
>>>   
>>>  ##
>>> +# @qom-list-getv:
>>> +#
>>> +# This command returns a list of properties and their values for
>>> +# each object path in the input list.
>> 
>> Imperative mood, please: "Return a list of ..."
>
> OK.  (I followed the style of qom-get and qom-list).

Yup.  We have a few more elsewhere.  I'll clean them up.

[...]