From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, Cleber Rosa <crosa@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH v2 5/5] qapi: delete un-needed python static analysis configs
Date: Tue, 22 Apr 2025 08:40:48 +0200 [thread overview]
Message-ID: <87fri08zrj.fsf@pond.sub.org> (raw)
In-Reply-To: <20250417213114.2336239-6-jsnow@redhat.com> (John Snow's message of "Thu, 17 Apr 2025 17:31:14 -0400")
John Snow <jsnow@redhat.com> writes:
> Since the previous commit, python/setup.cfg applies to scripts/qapi/ as
> well. Configuration files in scripts/qapi/ override python/setup.cfg.
>
> scripts/qapi/.flake8 and scripts/qapi/.isort.cfg actually match
> python/setup.cfg exactly, and can go.
>
> The differences between scripts/qapi/mypy.ini and python/setup.cfg are
> harmless: warn_unused_configs is actually the default for strict, so
> this is vestigial.
Could you insert my "[PATCH] python: Drop redundant warn_unused_configs
= True" right before this patch, and delete the explanation?
> namespace_packages being set to True is a requirement
> for the PEP420 nested package structure of QEMU but not for
> scripts/qapi, but has no effect on type checking the QAPI
> code. warn_unused_ignores is used in python/ to be able to target a wide
> variety of mypy versions; some of which that have added new ignore
> categories that are not present in older versions.
>
> Ultimately, scripts/qapi/mypy.ini can be removed without any real change
> in behavior to how mypy enforces type safety there.
>
> The pylint config is being left in place because the settings differ
> enough from the python/ directory settings that we need a chit-chat on
> how to merge them O:-)
>
> Signed-off-by: John Snow <jsnow@redhat.com>
prev parent reply other threads:[~2025-04-22 6:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 21:31 [PATCH v2 0/5] python: add QAPI and qapidoc et al to python linter tests John Snow
2025-04-17 21:31 ` [PATCH v2 1/5] qapi: Add some pylint ignores John Snow
2025-04-17 21:31 ` [PATCH v2 2/5] docs/qapidoc: linting fixes John Snow
2025-04-17 21:31 ` [PATCH v2 3/5] python: update missing dependencies from minreqs John Snow
2025-04-17 21:31 ` [PATCH v2 4/5] python: add qapi static analysis tests John Snow
2025-04-17 21:31 ` [PATCH v2 5/5] qapi: delete un-needed python static analysis configs John Snow
2025-04-22 6:40 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fri08zrj.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=jsnow@redhat.com \
--cc=michael.roth@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.