All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philippe Gerum <rpm@xenomai.org>
To: Florian Bezdeka <florian.bezdeka@siemens.com>
Cc: Xenomai <xenomai@lists.linux.dev>
Subject: Re: [Dovetail] v6.14: fix up to oob page pool
Date: Mon, 03 Mar 2025 15:25:22 +0100	[thread overview]
Message-ID: <87frju2nu5.fsf@xenomai.org> (raw)
In-Reply-To: <3f7587adac06cf5384e763c364baa55733d3ced4.camel@siemens.com> (Florian Bezdeka's message of "Mon, 03 Mar 2025 15:19:58 +0100")

Florian Bezdeka <florian.bezdeka@siemens.com> writes:

> On Mon, 2025-03-03 at 15:11 +0100, Philippe Gerum wrote:
>> Hi Florian,
>> 
>> For some reason, the hunk below disappeared from the Dovetail v6.13 code
>> when rebasing on v6.14-rc, this causes a crash at boot when
>> CONFIG_PAGE_POOL_OOB is turned on. This fix up should be merged to:
>> 
>> e4ecbcc40e7e6 net: dovetail: add infrastructure for oob device I/O
>> 
>> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
>> index 7860c3a88c5d2..07ad13dd5ed2e 100644
>> --- a/net/core/page_pool.c
>> +++ b/net/core/page_pool.c
>> @@ -563,7 +563,7 @@ static noinline netmem_ref __page_pool_alloc_pages_slow(struct page_pool *pool,
>>  		return pool->alloc.cache[--pool->alloc.count];
>>  
>>  	/* Mark empty alloc.cache slots "empty" for alloc_pages_bulk */
>> -	memset(&pool->alloc.cache, 0, sizeof(void *) * bulk);
>> +	memset(pool->alloc.cache, 0, sizeof(void *) * bulk);
>>  
>>  	nr_pages = alloc_pages_bulk_node(gfp, pool->p.nid, bulk,
>>  					 (struct page **)pool->alloc.cache);
>> 
>
> I will take care of that. I'm currently rebasing on top of 6.14-rc5.

Ok. Meanwhile, I'm preparing a patch to fix the hard irq context
detection (inverted test of IRQS_DEFERRED). We need to have that one as
a separate patch for backporting.

-- 
Philippe.

  reply	other threads:[~2025-03-03 14:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03 14:11 [Dovetail] v6.14: fix up to oob page pool Philippe Gerum
2025-03-03 14:19 ` Florian Bezdeka
2025-03-03 14:25   ` Philippe Gerum [this message]
2025-03-03 14:44     ` Florian Bezdeka
2025-03-04  9:54       ` Philippe Gerum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frju2nu5.fsf@xenomai.org \
    --to=rpm@xenomai.org \
    --cc=florian.bezdeka@siemens.com \
    --cc=xenomai@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.