All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Nicolas Belin <nbelin@baylibre.com>,
	Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
	Safae Ouajih <souajih@baylibre.com>,
	Ahmad Draidi <ar2000jp@gmail.com>
Cc: u-boot@lists.denx.de, Nicolas Belin <nbelin@baylibre.com>
Subject: Re: [PATCH 2/4] boot: android: free newbootargs when done
Date: Mon, 16 Dec 2024 09:00:27 +0100	[thread overview]
Message-ID: <87frmoxdk4.fsf@baylibre.com> (raw)
In-Reply-To: <20241211-fix-bootargs-concatenation-v1-2-c6752bcb9dde@baylibre.com>

Hi Nicolas,

Thank you for the patch.

On mer., déc. 11, 2024 at 14:53, Nicolas Belin <nbelin@baylibre.com> wrote:

> Free newbootargs when the concatenation is done and bootargs env
> is set.
>
> Fixes: 86f4695b ("image: Fix Android boot image support")
> Signed-off-by: Nicolas Belin <nbelin@baylibre.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  boot/image-android.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/boot/image-android.c b/boot/image-android.c
> index 57158280b41c6552c82838e21384d925d5f7cde4..362a5c7435a3a8bcf7b674b96e31069a91a892b5 100644
> --- a/boot/image-android.c
> +++ b/boot/image-android.c
> @@ -322,6 +322,7 @@ int android_image_get_kernel(const void *hdr,
>  	}
>  
>  	env_set("bootargs", newbootargs);
> +	free(newbootargs);
>  
>  	if (os_data) {
>  		if (image_get_magic(ihdr) == IH_MAGIC) {
>
> -- 
> 2.34.1

  reply	other threads:[~2024-12-16  8:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11 13:53 [PATCH 0/4] boot: android: rework the bootargs concatenation Nicolas Belin
2024-12-11 13:53 ` [PATCH 1/4] boot: android: fix extra command line support Nicolas Belin
2024-12-16  7:58   ` Mattijs Korpershoek
2024-12-11 13:53 ` [PATCH 2/4] boot: android: free newbootargs when done Nicolas Belin
2024-12-16  8:00   ` Mattijs Korpershoek [this message]
2024-12-11 13:53 ` [PATCH 3/4] boot: android: rework bootargs concatenation Nicolas Belin
2024-12-16  8:41   ` Mattijs Korpershoek
2024-12-16 12:45     ` Nicolas Belin
2024-12-11 13:53 ` [PATCH 4/4] boot: android: reorder the length calculation order Nicolas Belin
2024-12-16  8:42   ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frmoxdk4.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=ar2000jp@gmail.com \
    --cc=nbelin@baylibre.com \
    --cc=sjg@chromium.org \
    --cc=souajih@baylibre.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.