From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] rtc: rzn1: reduce register access
Date: Fri, 22 Nov 2024 11:39:29 +0100 [thread overview]
Message-ID: <87frnjpn6m.fsf@bootlin.com> (raw)
In-Reply-To: <20241122101448.4374-3-wsa+renesas@sang-engineering.com> (Wolfram Sang's message of "Fri, 22 Nov 2024 11:14:48 +0100")
On 22/11/2024 at 11:14:48 +01, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> This RTC has special 32bit registers which return multiple of the same
> 8bit registers at once. Use these to minimize register access. Also, do
> the to/from BCD conversions right away, so 'tm' always contains values
> as described in time.h.
IIRC it was easier to write the other way, but it is probably more optimized
like that, so
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
However I don't feel comfortable commenting on patch 1, I'll let Alex check.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
Thanks,
Miquèl
next prev parent reply other threads:[~2024-11-22 10:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 10:14 [RFC PATCH 0/2] rtc: rzn1: simplify driver Wolfram Sang
2024-11-22 10:14 ` [RFC PATCH 1/2] rtc: rzn1: drop superfluous wday calculation Wolfram Sang
2024-11-22 23:26 ` Alexandre Belloni
2024-11-23 8:01 ` Wolfram Sang
2024-11-23 10:25 ` Alexandre Belloni
2024-11-24 15:51 ` Wolfram Sang
2024-11-22 10:14 ` [RFC PATCH 2/2] rtc: rzn1: reduce register access Wolfram Sang
2024-11-22 10:39 ` Miquel Raynal [this message]
2024-11-25 22:33 ` [RFC PATCH 0/2] rtc: rzn1: simplify driver Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frnjpn6m.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.