From: Jani Nikula <jani.nikula@linux.intel.com>
To: Francois Dugast <francois.dugast@intel.com>,
intel-xe@lists.freedesktop.org
Subject: Re: ✗ CI.KUnit: failure for drm/xe: Use fault injection infrastructure to find issues at probe time (rev2)
Date: Mon, 23 Sep 2024 15:00:14 +0300 [thread overview]
Message-ID: <87frpq60mp.fsf@intel.com> (raw)
In-Reply-To: <ZvFESJTCV91MrTfg@fdugast-desk>
On Mon, 23 Sep 2024, Francois Dugast <francois.dugast@intel.com> wrote:
> On Fri, Sep 20, 2024 at 01:52:17PM +0000, Patchwork wrote:
>> == Series Details ==
>>
>> Series: drm/xe: Use fault injection infrastructure to find issues at probe time (rev2)
>> URL : https://patchwork.freedesktop.org/series/138654/
>> State : failure
>>
>> == Summary ==
>>
>> + trap cleanup EXIT
>> + /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
>> ERROR:root:In file included from ../drivers/gpu/drm/xe/xe_guc_ads.c:8:
>> ../include/linux/fault-inject.h:97:15: error: unknown type name ‘bool’
>> 97 | static inline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
>> | ^~~~
>> ../include/linux/fault-inject.h:97:43: error: unknown type name ‘gfp_t’
>> 97 | static inline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
>> | ^~~~~
>> ../include/linux/fault-inject.h:106:57: error: unknown type name ‘gfp_t’
>> 106 | static inline int should_failslab(struct kmem_cache *s, gfp_t gfpflags)
>> | ^~~~~
>> make[7]: *** [../scripts/Makefile.build:244: drivers/gpu/drm/xe/xe_guc_ads.o] Error 1
>
> This build error occurs when CONFIG_FAULT_INJECTION=n due to missing inclusion
> of linux/types.h in linux/fault-inject.h. It is solved with Jani's series:
>
> https://lore.kernel.org/intel-xe/20240813121237.2382534-1-jani.nikula@intel.com/
These two are in Linus' master now, we'll get them after -rc1 and some
backmerges:
6ce2082fd3a2 ("fault-inject: improve build for CONFIG_FAULT_INJECTION=n")
ccbfd2df3018 ("drm/xe: clean up fault injection usage")
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-09-23 12:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 13:18 [PATCH v2] drm/xe: Use fault injection infrastructure to find issues at probe time Francois Dugast
2024-09-20 13:51 ` ✓ CI.Patch_applied: success for drm/xe: Use fault injection infrastructure to find issues at probe time (rev2) Patchwork
2024-09-20 13:51 ` ✓ CI.checkpatch: " Patchwork
2024-09-20 13:52 ` ✗ CI.KUnit: failure " Patchwork
2024-09-23 10:34 ` Francois Dugast
2024-09-23 12:00 ` Jani Nikula [this message]
2024-09-23 18:05 ` [PATCH v2] drm/xe: Use fault injection infrastructure to find issues at probe time Rodrigo Vivi
2024-09-24 12:58 ` Francois Dugast
2024-09-26 18:43 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frpq60mp.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=francois.dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.