From: Markus Armbruster <armbru@redhat.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Markus Armbruster <armbru@redhat.com>, <qemu-devel@nongnu.org>
Subject: Re: CxlCorErrorType member @retry-threshold is undocumented
Date: Fri, 09 Aug 2024 12:11:10 +0200 [thread overview]
Message-ID: <87frrej9a9.fsf@pond.sub.org> (raw)
In-Reply-To: <20240809110420.000061b0@Huawei.com> (Jonathan Cameron's message of "Fri, 9 Aug 2024 11:04:20 +0100")
Jonathan Cameron <Jonathan.Cameron@Huawei.com> writes:
> On Thu, 08 Aug 2024 19:51:26 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Hi Jonathan,
>>
>> You added the type in commit 415442a1b4a (hw/mem/cxl_type3: Add CXL RAS
>> Error Injection Support.) The doc comment is missing a description of
>> @retry-threshold. Can you supply me one? I'm happy to do the actual
>> patch.
>>
> Sorry!
>
> The CXL spec text is
>
> Retry Threshold Hit. (NUM_RETRY >= MAX_NUM_RETRY). Applicable only to 68B Flit Mode.
> + a reference to the local retry state machine (LRSM)
>
> So maybe
>
> "Retry threshold hit in the Local Retry State Machine, 68B Flits only."
Is "Local Retry State Machine" a name or a description? The former may
be capitalized, the latter not.
prev parent reply other threads:[~2024-08-09 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 17:51 CxlCorErrorType member @retry-threshold is undocumented Markus Armbruster
2024-08-09 10:04 ` Jonathan Cameron via
2024-08-09 10:11 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frrej9a9.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.