All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Colin Ian King <colin.i.king@gmail.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Tvrtko Ursulin <tursulin@ursulin.net>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] drm/i915/dp: Make read-only array bw_gbps static const
Date: Wed, 24 Jul 2024 13:05:56 +0300	[thread overview]
Message-ID: <87frrzf6kb.fsf@intel.com> (raw)
In-Reply-To: <20240722153937.574819-1-colin.i.king@gmail.com>

On Mon, 22 Jul 2024, Colin Ian King <colin.i.king@gmail.com> wrote:
> Don't populate the read-only array bw_gbps on the stack at run time,
> instead make it static const.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Pushed to drm-intel-next, thanks for the patch.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 59f11af3b0a1..a082ed8f5464 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3434,7 +3434,7 @@ static void intel_dp_get_pcon_dsc_cap(struct intel_dp *intel_dp)
>  
>  static int intel_dp_pcon_get_frl_mask(u8 frl_bw_mask)
>  {
> -	int bw_gbps[] = {9, 18, 24, 32, 40, 48};
> +	static const int bw_gbps[] = {9, 18, 24, 32, 40, 48};
>  	int i;
>  
>  	for (i = ARRAY_SIZE(bw_gbps) - 1; i >= 0; i--) {

-- 
Jani Nikula, Intel

      parent reply	other threads:[~2024-07-24 10:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 15:39 [PATCH][next] drm/i915/dp: Make read-only array bw_gbps static const Colin Ian King
2024-07-22 15:44 ` ✓ CI.Patch_applied: success for " Patchwork
2024-07-22 15:44 ` ✓ CI.checkpatch: " Patchwork
2024-07-22 15:46 ` ✓ CI.KUnit: " Patchwork
2024-07-22 16:00 ` ✓ CI.Build: " Patchwork
2024-07-22 16:03 ` ✓ CI.Hooks: " Patchwork
2024-07-22 16:05 ` ✗ CI.checksparse: warning " Patchwork
2024-07-22 16:25 ` ✓ CI.BAT: success " Patchwork
2024-07-22 17:17 ` ✗ CI.FULL: failure " Patchwork
2024-07-22 17:55 ` ✓ Fi.CI.BAT: success " Patchwork
2024-07-23  9:42 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-07-24 10:05 ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frrzf6kb.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=colin.i.king@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.