From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
eblake@redhat.com, devel@lists.libvirt.org, hreitz@redhat.com,
kwolf@redhat.com, jsnow@redhat.com, pkrempa@redhat.com,
f.ebner@proxmox.com
Subject: Re: [PATCH v2 6/7] qapi/block-core: derpecate block-job-change
Date: Thu, 18 Jul 2024 13:01:41 +0200 [thread overview]
Message-ID: <87frs7x8tm.fsf@pond.sub.org> (raw)
In-Reply-To: <20240626110124.374336-7-vsementsov@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Wed, 26 Jun 2024 14:01:23 +0300")
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
> That's a first step to move on newer job-* APIs.
>
> The difference between block-job-change and job-change is in
> find_block_job_locked() vs find_job_locked() functions. What's
> different?
>
> 1. find_block_job_locked() do check, is found job a block-job. This OK
Do you mean something like find_block_job_locked() finds only block
jobs, whereas find_job_locked() finds any kind of job?
> when moving to more generic API, no needs to document this change.
>
> 2. find_block_job_locked() reports DeviceNotActive on failure, when
> find_job_locked() reports GenericError. Still, for block-job-change
> errors are not documented at all, so be silent in deprecated.txt as
> well.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
next prev parent reply other threads:[~2024-07-18 11:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 11:01 [PATCH v2 0/7] introduce job-change qmp command Vladimir Sementsov-Ogievskiy
2024-06-26 11:01 ` [PATCH v2 1/7] qapi: rename BlockJobChangeOptions to JobChangeOptions Vladimir Sementsov-Ogievskiy
2024-07-18 10:54 ` Markus Armbruster
2024-06-26 11:01 ` [PATCH v2 2/7] blockjob: block_job_change_locked(): check job type Vladimir Sementsov-Ogievskiy
2024-06-26 11:01 ` [PATCH v2 3/7] qapi: block-job-change: make copy-mode parameter optional Vladimir Sementsov-Ogievskiy
2024-07-18 10:55 ` Markus Armbruster
2024-06-26 11:01 ` [PATCH v2 4/7] blockjob: move change action implementation to job from block-job Vladimir Sementsov-Ogievskiy
2024-06-26 11:01 ` [PATCH v2 5/7] qapi: add job-change Vladimir Sementsov-Ogievskiy
2024-07-18 10:59 ` Markus Armbruster
2024-08-02 11:10 ` Vladimir Sementsov-Ogievskiy
2024-06-26 11:01 ` [PATCH v2 6/7] qapi/block-core: derpecate block-job-change Vladimir Sementsov-Ogievskiy
2024-07-18 11:01 ` Markus Armbruster [this message]
2024-08-02 11:10 ` Vladimir Sementsov-Ogievskiy
2024-08-02 13:20 ` Markus Armbruster
2024-08-02 13:36 ` Markus Armbruster
2024-06-26 11:01 ` [PATCH v2 7/7] iotests/mirror-change-copy-mode: switch to job-change command Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frs7x8tm.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=devel@lists.libvirt.org \
--cc=eblake@redhat.com \
--cc=f.ebner@proxmox.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.