Re: [PATCH 00/11] usb: gadget: Introduce handle_interrupts ops to USB_GADGET_GENERIC uclass

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

Hi Marek,

Thank you for the series.

On ven., juin 14, 2024 at 02:51, Marek Vasut <marek.vasut+renesas@mailbox.org> wrote:

> Introduce .ops for USB_GADGET_GENERIC uclass. The first new ops is
> .handle_interrupts which must be implemented by DM capable USB gadget
> controller drivers and must implement interrupt handling similar to
> dm_usb_gadget_handle_interrupts(). For DM USB gadget drivers this is
> a replacement for dm_usb_gadget_handle_interrupts(). Convert the DM
> USB gadget drivers to this new ops instead.
>
> DEPENDS: https://patchwork.ozlabs.org/project/uboot/list/?series=410150
>
> Marek Vasut (11):
>   usb: gadget: Introduce handle_interrupts ops to USB_GADGET_GENERIC
>     uclass
>   usb: gadget: cdns3: Convert interrupt handling to
>     usb_gadget_generic_ops
>   usb: gadget: dwc2: Convert interrupt handling to
>     usb_gadget_generic_ops
>   usb: gadget: dwc3: Convert interrupt handling to
>     usb_gadget_generic_ops
>   usb: gadget: max3420: Convert interrupt handling to
>     usb_gadget_generic_ops
>   usb: gadget: mtu3: Convert interrupt handling to
>     usb_gadget_generic_ops
>   usb: gadget: omap2430: Convert interrupt handling to
>     usb_gadget_generic_ops
>   usb: gadget: musb: Convert interrupt handling to
>     usb_gadget_generic_ops
>   usb: gadget: ux500: Convert interrupt handling to
>     usb_gadget_generic_ops
>   usb: gadget: sandbox: Drop dm_usb_gadget_handle_interrupts()
>   usb: gadget: Mark dm_usb_gadget_handle_interrupts as non-weak for
>     DM_USB_GADGET
>
>  drivers/usb/cdns3/core.c            | 24 ++++++++++++++++++++++++
>  drivers/usb/cdns3/gadget-export.h   |  2 ++
>  drivers/usb/cdns3/gadget.c          | 11 +----------
>  drivers/usb/dwc3/dwc3-generic.c     | 23 ++++++++++++++---------
>  drivers/usb/dwc3/dwc3-layerscape.c  | 21 +++++++++++++--------
>  drivers/usb/gadget/dwc2_udc_otg.c   | 20 +++++++++++++++-----
>  drivers/usb/gadget/max3420_udc.c    | 19 ++++++++++++-------
>  drivers/usb/gadget/udc/udc-uclass.c | 24 ++++++++++++++++++++++++
>  drivers/usb/host/usb-sandbox.c      |  7 +------
>  drivers/usb/mtu3/mtu3_plat.c        | 23 ++++++++++++++---------
>  drivers/usb/musb-new/omap2430.c     | 26 ++++++++++++++++----------
>  drivers/usb/musb-new/ti-musb.c      | 23 ++++++++++++++---------
>  drivers/usb/musb-new/ux500.c        | 22 ++++++++++++++--------
>  include/linux/usb/gadget.h          |  8 ++++++++
>  14 files changed, 172 insertions(+), 81 deletions(-)

Tested on Khadas vim3 using fastboot, ums and usb storage scanning.

Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # vim3

>
> ---
> Cc: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: u-boot@lists.denx.de
>
> -- 
> 2.43.0