From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EC26C54E64 for ; Mon, 25 Mar 2024 14:37:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E8fJKt2PfZbD8m5wpPDbobU5+s4FJFPVQhJJ0P7MOSY=; b=eMxa/ca4G+zQTbtZc02RVFliwa 1ibV1aS1g8nkCgd6lZeRL/aYkr4Ogh4iQI3KkUHgeYW/dZ2gBZgd71fj81byUlprcAp4Bb5LRd3Ce rukBguhOHbSbPnoAzkohLlOr4+XrYtQT8U4rwfvNFwfDxIrwIca9r8I3XZ+EFsPUjxfYV0VjP5cYf u766PP4k5DPCQhcs9vgqbR1btMzjHsNmK+b/QVl122zSkyys23EN3TD+cEzO2RYTzrAdl/MjzQkBJ 5JmNtckm0NHzhRvyN4sUwcIcKg7HN+zHo8Wo9BbbdBi81djnu7mPvCjrnDYAQjfoLzmnPDvXfvP+m a/BRI4kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rolSU-00000000Gvx-14E1; Mon, 25 Mar 2024 14:37:54 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rolSJ-00000000Gpe-06CV; Mon, 25 Mar 2024 14:37:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BDCDBCE0EE1; Mon, 25 Mar 2024 14:37:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD6A9C433F1; Mon, 25 Mar 2024 14:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711377460; bh=onRjf8TNnnxKbpEukinv+PxWlrvYWsRWXbj+9065TiI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OIy8Tezfr7vjlKApvzlLdl9x/9IAlZTNi8IbuxVJJEIJDM307bxfAiiFX03rew6jx 5Qswry5F75Fkkz1oKNVdx4J2nbKtY4XcShVEcus9lZnicasyTyxnfXw9OI92byUPdZ kF0v2NCysr612g9LLir9A5zKBt51QEg9oZBDQV3hlMP3viCQA5GXhU75VPpoJujI6S ESpukxkN8anYl87WTYPp7yTQePkGw88A8zuZA2dhop/fBxEb/tLaLkpIcqgKOPSJ1p qZFwIUqUMbwmdHYUDAkyEqIu2ia7miGLkZf/y3aVsHiaR1Q5ccUEw5j2up2g+mHEJ3 DRt81EfjvJCzQ== From: Kalle Valo To: Bartosz Golaszewski Cc: Marcel Holtmann , Luiz Augusto von Dentz , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Catalin Marinas , Will Deacon , Bjorn Helgaas , Saravana Kannan , Geert Uytterhoeven , Arnd Bergmann , Neil Armstrong , Marek Szyprowski , Alex Elder , Srini Kandagatla , Greg Kroah-Hartman , Abel Vesa , Manivannan Sadhasivam , Lukas Wunner , Dmitry Baryshkov , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Bartosz Golaszewski , ath11k@lists.infradead.org, Johan Hovold Subject: Re: [PATCH v6 04/16] dt-bindings: net: wireless: qcom,ath11k: describe the ath11k on QCA6390 References: <20240325131624.26023-1-brgl@bgdev.pl> <20240325131624.26023-5-brgl@bgdev.pl> <87r0fy8lde.fsf@kernel.org> Date: Mon, 25 Mar 2024 16:37:29 +0200 In-Reply-To: (Bartosz Golaszewski's message of "Mon, 25 Mar 2024 15:09:12 +0100") Message-ID: <87frwe8jiu.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240325_073743_904611_57DA7EF1 X-CRM114-Status: GOOD ( 17.04 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org Bartosz Golaszewski writes: > On Mon, Mar 25, 2024 at 2:57=E2=80=AFPM Kalle Valo wro= te: > >> >> Bartosz Golaszewski writes: >> >> > From: Bartosz Golaszewski >> > >> > Add a PCI compatible for the ATH11K module on QCA6390 and describe the >> > power inputs from the PMU that it consumes. >> > >> > Signed-off-by: Bartosz Golaszewski >> >> [...] >> >> > +allOf: >> > + - if: >> > + properties: >> > + compatible: >> > + contains: >> > + const: pci17cb,1101 >> > + then: >> > + required: >> > + - vddrfacmn-supply >> > + - vddaon-supply >> > + - vddwlcx-supply >> > + - vddwlmx-supply >> > + - vddrfa0p8-supply >> > + - vddrfa1p2-supply >> > + - vddrfa1p7-supply >> > + - vddpcie0p9-supply >> > + - vddpcie1p8-supply >> >> I don't know DT well enough to know what the "required:" above means, >> but does this take into account that there are normal "plug&play" type >> of QCA6390 boards as well which don't need any DT settings? > > Do they require a DT node though for some reason? You can attach the device to any PCI slot, connect the WLAN antenna and it just works without DT nodes. I'm trying to make sure here that basic setup still works. Adding also Johan and ath11k list. For example, I don't know what's the plan with Lenovo X13s, will it use this framework? I guess in theory we could have devices which use qcom,ath11k-calibration-variant from DT but not any of these supply properties? --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5184EC54E58 for ; Mon, 25 Mar 2024 14:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u+xh60gJ//vA2WaS4B7Qni3zIEV1vjtlUBVRrAkOuwo=; b=ghabbXyBrF/EuR LO3nZBn8kddKlRxjIUkzBSaJVKWMeJsI4YoC+o9S44hUzS5o/SRejyFZutVMegmrMyXY9dr1Rjnjz LcODnwjgqKwJgTVpIFAAWbzaL6ZFBT4G09umw7xKhHLMEA5+j2hUGHPYoIh7BV4bDIusy2eSNGt1K Swb4HGrL7BgOM61uZZleSLzip7V+4kdnNtLltl+V1R1A3cbv8j30q28FDHkd6chnJ3h0zRX/c0dVl Dubmv5hI7GJw6HtGbYOjPpeR+34v28x/oYYx8M32gxcPCWxbXOzvI/vKHeT0/ZHhAbCw3UTcD5FTQ 6FmEYmXHvIO0ZxnTEVIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rolSZ-00000000Gz6-078F; Mon, 25 Mar 2024 14:38:00 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rolSJ-00000000Gpe-06CV; Mon, 25 Mar 2024 14:37:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BDCDBCE0EE1; Mon, 25 Mar 2024 14:37:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD6A9C433F1; Mon, 25 Mar 2024 14:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711377460; bh=onRjf8TNnnxKbpEukinv+PxWlrvYWsRWXbj+9065TiI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OIy8Tezfr7vjlKApvzlLdl9x/9IAlZTNi8IbuxVJJEIJDM307bxfAiiFX03rew6jx 5Qswry5F75Fkkz1oKNVdx4J2nbKtY4XcShVEcus9lZnicasyTyxnfXw9OI92byUPdZ kF0v2NCysr612g9LLir9A5zKBt51QEg9oZBDQV3hlMP3viCQA5GXhU75VPpoJujI6S ESpukxkN8anYl87WTYPp7yTQePkGw88A8zuZA2dhop/fBxEb/tLaLkpIcqgKOPSJ1p qZFwIUqUMbwmdHYUDAkyEqIu2ia7miGLkZf/y3aVsHiaR1Q5ccUEw5j2up2g+mHEJ3 DRt81EfjvJCzQ== From: Kalle Valo To: Bartosz Golaszewski Cc: Marcel Holtmann , Luiz Augusto von Dentz , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Catalin Marinas , Will Deacon , Bjorn Helgaas , Saravana Kannan , Geert Uytterhoeven , Arnd Bergmann , Neil Armstrong , Marek Szyprowski , Alex Elder , Srini Kandagatla , Greg Kroah-Hartman , Abel Vesa , Manivannan Sadhasivam , Lukas Wunner , Dmitry Baryshkov , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Bartosz Golaszewski , ath11k@lists.infradead.org, Johan Hovold Subject: Re: [PATCH v6 04/16] dt-bindings: net: wireless: qcom,ath11k: describe the ath11k on QCA6390 References: <20240325131624.26023-1-brgl@bgdev.pl> <20240325131624.26023-5-brgl@bgdev.pl> <87r0fy8lde.fsf@kernel.org> Date: Mon, 25 Mar 2024 16:37:29 +0200 In-Reply-To: (Bartosz Golaszewski's message of "Mon, 25 Mar 2024 15:09:12 +0100") Message-ID: <87frwe8jiu.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240325_073743_904611_57DA7EF1 X-CRM114-Status: GOOD ( 17.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QmFydG9zeiBHb2xhc3pld3NraSA8YnJnbEBiZ2Rldi5wbD4gd3JpdGVzOgoKPiBPbiBNb24sIE1h ciAyNSwgMjAyNCBhdCAyOjU34oCvUE0gS2FsbGUgVmFsbyA8a3ZhbG9Aa2VybmVsLm9yZz4gd3Jv dGU6Cj4KPj4KPj4gQmFydG9zeiBHb2xhc3pld3NraSA8YnJnbEBiZ2Rldi5wbD4gd3JpdGVzOgo+ Pgo+PiA+IEZyb206IEJhcnRvc3ogR29sYXN6ZXdza2kgPGJhcnRvc3ouZ29sYXN6ZXdza2lAbGlu YXJvLm9yZz4KPj4gPgo+PiA+IEFkZCBhIFBDSSBjb21wYXRpYmxlIGZvciB0aGUgQVRIMTFLIG1v ZHVsZSBvbiBRQ0E2MzkwIGFuZCBkZXNjcmliZSB0aGUKPj4gPiBwb3dlciBpbnB1dHMgZnJvbSB0 aGUgUE1VIHRoYXQgaXQgY29uc3VtZXMuCj4+ID4KPj4gPiBTaWduZWQtb2ZmLWJ5OiBCYXJ0b3N6 IEdvbGFzemV3c2tpIDxiYXJ0b3N6LmdvbGFzemV3c2tpQGxpbmFyby5vcmc+Cj4+Cj4+IFsuLi5d Cj4+Cj4+ID4gK2FsbE9mOgo+PiA+ICsgIC0gaWY6Cj4+ID4gKyAgICAgIHByb3BlcnRpZXM6Cj4+ ID4gKyAgICAgICAgY29tcGF0aWJsZToKPj4gPiArICAgICAgICAgIGNvbnRhaW5zOgo+PiA+ICsg ICAgICAgICAgICBjb25zdDogcGNpMTdjYiwxMTAxCj4+ID4gKyAgICB0aGVuOgo+PiA+ICsgICAg ICByZXF1aXJlZDoKPj4gPiArICAgICAgICAtIHZkZHJmYWNtbi1zdXBwbHkKPj4gPiArICAgICAg ICAtIHZkZGFvbi1zdXBwbHkKPj4gPiArICAgICAgICAtIHZkZHdsY3gtc3VwcGx5Cj4+ID4gKyAg ICAgICAgLSB2ZGR3bG14LXN1cHBseQo+PiA+ICsgICAgICAgIC0gdmRkcmZhMHA4LXN1cHBseQo+ PiA+ICsgICAgICAgIC0gdmRkcmZhMXAyLXN1cHBseQo+PiA+ICsgICAgICAgIC0gdmRkcmZhMXA3 LXN1cHBseQo+PiA+ICsgICAgICAgIC0gdmRkcGNpZTBwOS1zdXBwbHkKPj4gPiArICAgICAgICAt IHZkZHBjaWUxcDgtc3VwcGx5Cj4+Cj4+IEkgZG9uJ3Qga25vdyBEVCB3ZWxsIGVub3VnaCB0byBr bm93IHdoYXQgdGhlICJyZXF1aXJlZDoiIGFib3ZlIG1lYW5zLAo+PiBidXQgZG9lcyB0aGlzIHRh a2UgaW50byBhY2NvdW50IHRoYXQgdGhlcmUgYXJlIG5vcm1hbCAicGx1ZyZwbGF5IiB0eXBlCj4+ IG9mIFFDQTYzOTAgYm9hcmRzIGFzIHdlbGwgd2hpY2ggZG9uJ3QgbmVlZCBhbnkgRFQgc2V0dGlu Z3M/Cj4KPiBEbyB0aGV5IHJlcXVpcmUgYSBEVCBub2RlIHRob3VnaCBmb3Igc29tZSByZWFzb24/ CgpZb3UgY2FuIGF0dGFjaCB0aGUgZGV2aWNlIHRvIGFueSBQQ0kgc2xvdCwgY29ubmVjdCB0aGUg V0xBTiBhbnRlbm5hIGFuZAppdCBqdXN0IHdvcmtzIHdpdGhvdXQgRFQgbm9kZXMuIEknbSB0cnlp bmcgdG8gbWFrZSBzdXJlIGhlcmUgdGhhdCBiYXNpYwpzZXR1cCBzdGlsbCB3b3Jrcy4KCkFkZGlu ZyBhbHNvIEpvaGFuIGFuZCBhdGgxMWsgbGlzdC4gRm9yIGV4YW1wbGUsIEkgZG9uJ3Qga25vdyB3 aGF0J3MgdGhlCnBsYW4gd2l0aCBMZW5vdm8gWDEzcywgd2lsbCBpdCB1c2UgdGhpcyBmcmFtZXdv cms/IEkgZ3Vlc3MgaW4gdGhlb3J5IHdlCmNvdWxkIGhhdmUgZGV2aWNlcyB3aGljaCB1c2UgcWNv bSxhdGgxMWstY2FsaWJyYXRpb24tdmFyaWFudCBmcm9tIERUIGJ1dApub3QgYW55IG9mIHRoZXNl IHN1cHBseSBwcm9wZXJ0aWVzPwoKLS0gCmh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJv amVjdC9saW51eC13aXJlbGVzcy9saXN0LwoKaHR0cHM6Ly93aXJlbGVzcy53aWtpLmtlcm5lbC5v cmcvZW4vZGV2ZWxvcGVycy9kb2N1bWVudGF0aW9uL3N1Ym1pdHRpbmdwYXRjaGVzCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==