All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Manorit Chawdhry <m-chawdhry@ti.com>,
	Siddharth Vadapalli <s-vadapalli@ti.com>,
	Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Manorit Chawdhry <m-chawdhry@ti.com>
Subject: Re: [PATCH 2/2] include: env: ti: add default for do_main_cpsw0_qsgmii_phyinit
Date: Tue, 09 Jan 2024 15:29:34 +0100	[thread overview]
Message-ID: <87frz6wpf5.fsf@baylibre.com> (raw)
In-Reply-To: <20240108-b4-upstream-fix-semicolon-v1-2-9437b3dc90ea@ti.com>

Hi Manorit,

Thank you for the patch.

On lun., janv. 08, 2024 at 13:48, Manorit Chawdhry <m-chawdhry@ti.com> wrote:

> By default this variable is unset and this causes the test condition to
> fail on devices that don't have this defined. Set a default value for
> this.
>
>    => boot
>    ## Error: "main_cpsw0_qsgmii_phyinit" not defined
>    [...]
>
> Fixes: 0d72b0f2f83b ("include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally")
>
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  include/env/ti/ti_common.env | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/env/ti/ti_common.env b/include/env/ti/ti_common.env
> index 5473f633aa7d..02b410c3adc4 100644
> --- a/include/env/ti/ti_common.env
> +++ b/include/env/ti/ti_common.env
> @@ -22,6 +22,7 @@ get_fit_overlaystring=
>  	done;
>  get_fit_config=setexpr name_fit_config gsub / _ conf-${fdtfile}
>  run_fit=run get_fit_config; bootm ${addr_fit}#${name_fit_config}${overlaystring}
> +do_main_cpsw0_qsgmii_phyinit=0
>  bootcmd_ti_mmc=
>  	run findfdt; run init_${boot};
>  #if CONFIG_CMD_REMOTEPROC
>
> -- 
> 2.43.0

  reply	other threads:[~2024-01-09 14:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08  8:18 [PATCH 0/2] Boot fixup Manorit Chawdhry
2024-01-08  8:18 ` [PATCH 1/2] include: env: ti: ti_common: Fix a missing semicolon Manorit Chawdhry
2024-01-09 14:16   ` Mattijs Korpershoek
2024-01-19 16:08   ` Tom Rini
2024-01-08  8:18 ` [PATCH 2/2] include: env: ti: add default for do_main_cpsw0_qsgmii_phyinit Manorit Chawdhry
2024-01-09 14:29   ` Mattijs Korpershoek [this message]
2024-01-19 16:08   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frz6wpf5.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=m-chawdhry@ti.com \
    --cc=s-vadapalli@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.