From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1qpjLW-00045w-E6 for mharc-qemu-trivial@gnu.org; Mon, 09 Oct 2023 02:02:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpjLT-00045e-UP for qemu-trivial@nongnu.org; Mon, 09 Oct 2023 02:02:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpjLP-0007IU-R5 for qemu-trivial@nongnu.org; Mon, 09 Oct 2023 02:02:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696831336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A49hkj4iH4M3cdIFcvi7sUJ79wl/wVgoa2Ki1/b2gvk=; b=MuB3S1rodBF2LZZp0dWxGbgRk4X3wo74i/hGAGDNw0zAsy/ZQ0WL0bgFiyoOm9tCr35dsw 172v5nO4V0UAd/JbfkZwkIJAUfxNzVgEWjKVaj9HNCGirPhgHoBOTYLcEVEySxJVsjP0LU iClFd88kUcw4Dee4HKss/6vffp95+Uo= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-322-WSH3PzFkNNebcuWKao3A9A-1; Mon, 09 Oct 2023 02:02:14 -0400 X-MC-Unique: WSH3PzFkNNebcuWKao3A9A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 901CB3800E9A; Mon, 9 Oct 2023 06:02:14 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9EFE63F53; Mon, 9 Oct 2023 06:02:13 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C480621E6904; Mon, 9 Oct 2023 08:02:12 +0200 (CEST) From: Markus Armbruster To: Michael Tokarev Cc: "Michael S. Tsirkin" , Thomas Huth , qemu-devel@nongnu.org, qemu-trivial@nongnu.org Subject: Re: [PATCH] hw/virtio/vhost: Silence compiler warnings in vhost code when using -Wshadow References: <20231004114809.105672-1-thuth@redhat.com> <18f1faab-71f4-4dbd-a319-fcd65721f58b@tls.msk.ru> <87h6n4p1ts.fsf@pond.sub.org> <29a2a188-ec5b-452f-be63-92e8f0ec7110@tls.msk.ru> <20231006072416-mutt-send-email-mst@kernel.org> <88329105-bec2-461e-8c40-bbb5b66636b1@tls.msk.ru> Date: Mon, 09 Oct 2023 08:02:12 +0200 In-Reply-To: <88329105-bec2-461e-8c40-bbb5b66636b1@tls.msk.ru> (Michael Tokarev's message of "Sat, 7 Oct 2023 12:28:26 +0300") Message-ID: <87fs2k72qj.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2023 06:02:24 -0000 Michael Tokarev writes: > 06.10.2023 14:24, Michael S. Tsirkin: >> On Fri, Oct 06, 2023 at 01:45:51PM +0300, Michael Tokarev wrote: >>> 06.10.2023 11:55, Markus Armbruster =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> Michael Tokarev writes: >>>> >>>>> Applied to my trivial-patches tree, thanks! >>>>> >>>>> Marcus, you picked up previous patches of this theme, -- >>>>> you can continue this tradition if you like :) >>>> >>>> I intend to post a pull request for the -Wshadow patches that have >>>> R-bys. I'm also tracking the unreviewed ones, and hope they get >>>> reviewed. >>> >>> Ahh, ok. >>> >>> I've added my own R-bys for the ones I picked up, and for this one >>> by Thomas too: >>> >>> Reviewed-By: Michael Tokarev >> >> it would be better to deal with all of them in one place tbh. > > This is exactly why I asked Marcus about this in the first place, > being confused a bit with the stuff being especially sent to > qemu-trivial@ :) This patch is in my latest PR[*], along with all the other shadow patches that were ready at the time. A few more are coming down the pipe, which I can take through my tree, too. [*] [PULL 00/32] -Wshadow=3Dlocal patches patches for 2023-10-06 Message-ID: <20231006113657.3803180-1-armbru@redhat.com>