From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD4EAEE49A6 for ; Mon, 21 Aug 2023 22:44:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 332E910E100; Mon, 21 Aug 2023 22:44:02 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 74B9110E100; Mon, 21 Aug 2023 22:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692657840; x=1724193840; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=eUcLYc0J7HowPfeJ9TjzTc9ALeAmarKJjBj1No+r/5M=; b=dkJ53OgkMx8BUXiRTXdT3T1ZiReZc825FrcvwhI3J5prmZx5m/bbAlKZ reIkIAY+uOExzPeB/041SrEoQwnjmMTbcII9SeNrXN/oTlG0imMeiIjgy qBvNmreXuC8JPkJVRdLQinVPIxTmj87aKit4gLQvF30Svfe+wE6dpeOxF eJYHKuwfCO0guZhvPxkKNTU5uoulLlZgmU3aWTaX+MBTfPfSTltYtDmTf 5mkinWS6UeonBE3onlHf0WxQVw+lPePVEA5Xuj3bj4B6cbBpA+TMe+B2T ippDOGIPJ9pnn2xsei/EpPlwV8WX2YowZJRQ13nUcwMVh6fR3+RqnaFAR w==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="358702729" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="358702729" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 15:44:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="859659922" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="859659922" Received: from hpabst-mobl.ger.corp.intel.com (HELO localhost) ([10.252.54.190]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 15:43:55 -0700 From: Jani Nikula To: Nikita B , joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com, airlied@gmail.com, daniel@ffwll.ch, daniele.ceraolospurio@intel.com, John.C.Harrison@Intel.com, alan.previn.teres.alexis@intel.com, gregkh@linuxfoundation.org, harshit.m.mogalapalli@oracle.com, michal.wajdeczko@intel.com, skhan@linuxfoundation.org In-Reply-To: <20230821192718.504357-1-n2h9z4@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230821192718.504357-1-n2h9z4@gmail.com> Date: Tue, 22 Aug 2023 01:43:52 +0300 Message-ID: <87fs4c6mon.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH v1] drivers: gpu: drm: i915: intel_huc: fix formatting warnings X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nikita B , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 21 Aug 2023, Nikita B wrote: > Fix formatting warnings when run "make htmldocs": > ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:29: WARNING: Unexpected indentation. > ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:30: WARNING: Block quote ends without a blank line; unexpected unindent. > ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:35: WARNING: Bullet list ends without a blank line; unexpected unindent. > > Signed-off-by: Nikita B Already fixed by commit 175b036472f6 ("drm/i915: fix Sphinx indentation warning") in drm-next. BR, Jani. > --- > drivers/gpu/drm/i915/gt/uc/intel_huc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c b/drivers/gpu/drm/i915/gt/uc/intel_huc.c > index ddd146265beb..fa70defcb5b2 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_huc.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc.c > @@ -26,6 +26,7 @@ > * The kernel driver is only responsible for loading the HuC firmware and > * triggering its security authentication. This is done differently depending > * on the platform: > + * > * - older platforms (from Gen9 to most Gen12s): the load is performed via DMA > * and the authentication via GuC > * - DG2: load and authentication are both performed via GSC. > @@ -33,6 +34,7 @@ > * not-DG2 older platforms), while the authentication is done in 2-steps, > * a first auth for clear-media workloads via GuC and a second one for all > * workloads via GSC. > + * > * On platforms where the GuC does the authentication, to correctly do so the > * HuC binary must be loaded before the GuC one. > * Loading the HuC is optional; however, not using the HuC might negatively -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF569EE49A5 for ; Mon, 21 Aug 2023 22:44:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DB7DD10E11C; Mon, 21 Aug 2023 22:44:02 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 74B9110E100; Mon, 21 Aug 2023 22:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692657840; x=1724193840; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=eUcLYc0J7HowPfeJ9TjzTc9ALeAmarKJjBj1No+r/5M=; b=dkJ53OgkMx8BUXiRTXdT3T1ZiReZc825FrcvwhI3J5prmZx5m/bbAlKZ reIkIAY+uOExzPeB/041SrEoQwnjmMTbcII9SeNrXN/oTlG0imMeiIjgy qBvNmreXuC8JPkJVRdLQinVPIxTmj87aKit4gLQvF30Svfe+wE6dpeOxF eJYHKuwfCO0guZhvPxkKNTU5uoulLlZgmU3aWTaX+MBTfPfSTltYtDmTf 5mkinWS6UeonBE3onlHf0WxQVw+lPePVEA5Xuj3bj4B6cbBpA+TMe+B2T ippDOGIPJ9pnn2xsei/EpPlwV8WX2YowZJRQ13nUcwMVh6fR3+RqnaFAR w==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="358702729" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="358702729" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 15:44:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="859659922" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="859659922" Received: from hpabst-mobl.ger.corp.intel.com (HELO localhost) ([10.252.54.190]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 15:43:55 -0700 From: Jani Nikula To: Nikita B , joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com, airlied@gmail.com, daniel@ffwll.ch, daniele.ceraolospurio@intel.com, John.C.Harrison@Intel.com, alan.previn.teres.alexis@intel.com, gregkh@linuxfoundation.org, harshit.m.mogalapalli@oracle.com, michal.wajdeczko@intel.com, skhan@linuxfoundation.org Subject: Re: [PATCH v1] drivers: gpu: drm: i915: intel_huc: fix formatting warnings In-Reply-To: <20230821192718.504357-1-n2h9z4@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230821192718.504357-1-n2h9z4@gmail.com> Date: Tue, 22 Aug 2023 01:43:52 +0300 Message-ID: <87fs4c6mon.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nikita B , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 21 Aug 2023, Nikita B wrote: > Fix formatting warnings when run "make htmldocs": > ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:29: WARNING: Unexpected indentation. > ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:30: WARNING: Block quote ends without a blank line; unexpected unindent. > ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:35: WARNING: Bullet list ends without a blank line; unexpected unindent. > > Signed-off-by: Nikita B Already fixed by commit 175b036472f6 ("drm/i915: fix Sphinx indentation warning") in drm-next. BR, Jani. > --- > drivers/gpu/drm/i915/gt/uc/intel_huc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c b/drivers/gpu/drm/i915/gt/uc/intel_huc.c > index ddd146265beb..fa70defcb5b2 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_huc.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc.c > @@ -26,6 +26,7 @@ > * The kernel driver is only responsible for loading the HuC firmware and > * triggering its security authentication. This is done differently depending > * on the platform: > + * > * - older platforms (from Gen9 to most Gen12s): the load is performed via DMA > * and the authentication via GuC > * - DG2: load and authentication are both performed via GSC. > @@ -33,6 +34,7 @@ > * not-DG2 older platforms), while the authentication is done in 2-steps, > * a first auth for clear-media workloads via GuC and a second one for all > * workloads via GSC. > + * > * On platforms where the GuC does the authentication, to correctly do so the > * HuC binary must be loaded before the GuC one. > * Loading the HuC is optional; however, not using the HuC might negatively -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE227EE4996 for ; Mon, 21 Aug 2023 22:44:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231593AbjHUWoC (ORCPT ); Mon, 21 Aug 2023 18:44:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjHUWoB (ORCPT ); Mon, 21 Aug 2023 18:44:01 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6444F11C for ; Mon, 21 Aug 2023 15:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692657840; x=1724193840; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=eUcLYc0J7HowPfeJ9TjzTc9ALeAmarKJjBj1No+r/5M=; b=dkJ53OgkMx8BUXiRTXdT3T1ZiReZc825FrcvwhI3J5prmZx5m/bbAlKZ reIkIAY+uOExzPeB/041SrEoQwnjmMTbcII9SeNrXN/oTlG0imMeiIjgy qBvNmreXuC8JPkJVRdLQinVPIxTmj87aKit4gLQvF30Svfe+wE6dpeOxF eJYHKuwfCO0guZhvPxkKNTU5uoulLlZgmU3aWTaX+MBTfPfSTltYtDmTf 5mkinWS6UeonBE3onlHf0WxQVw+lPePVEA5Xuj3bj4B6cbBpA+TMe+B2T ippDOGIPJ9pnn2xsei/EpPlwV8WX2YowZJRQ13nUcwMVh6fR3+RqnaFAR w==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="358702727" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="358702727" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 15:44:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="859659922" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="859659922" Received: from hpabst-mobl.ger.corp.intel.com (HELO localhost) ([10.252.54.190]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 15:43:55 -0700 From: Jani Nikula To: Nikita B , joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com, airlied@gmail.com, daniel@ffwll.ch, daniele.ceraolospurio@intel.com, John.C.Harrison@Intel.com, alan.previn.teres.alexis@intel.com, gregkh@linuxfoundation.org, harshit.m.mogalapalli@oracle.com, michal.wajdeczko@intel.com, skhan@linuxfoundation.org Cc: Nikita B , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] drivers: gpu: drm: i915: intel_huc: fix formatting warnings In-Reply-To: <20230821192718.504357-1-n2h9z4@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230821192718.504357-1-n2h9z4@gmail.com> Date: Tue, 22 Aug 2023 01:43:52 +0300 Message-ID: <87fs4c6mon.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Aug 2023, Nikita B wrote: > Fix formatting warnings when run "make htmldocs": > ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:29: WARNING: Unexpected indentation. > ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:30: WARNING: Block quote ends without a blank line; unexpected unindent. > ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:35: WARNING: Bullet list ends without a blank line; unexpected unindent. > > Signed-off-by: Nikita B Already fixed by commit 175b036472f6 ("drm/i915: fix Sphinx indentation warning") in drm-next. BR, Jani. > --- > drivers/gpu/drm/i915/gt/uc/intel_huc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c b/drivers/gpu/drm/i915/gt/uc/intel_huc.c > index ddd146265beb..fa70defcb5b2 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_huc.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc.c > @@ -26,6 +26,7 @@ > * The kernel driver is only responsible for loading the HuC firmware and > * triggering its security authentication. This is done differently depending > * on the platform: > + * > * - older platforms (from Gen9 to most Gen12s): the load is performed via DMA > * and the authentication via GuC > * - DG2: load and authentication are both performed via GSC. > @@ -33,6 +34,7 @@ > * not-DG2 older platforms), while the authentication is done in 2-steps, > * a first auth for clear-media workloads via GuC and a second one for all > * workloads via GSC. > + * > * On platforms where the GuC does the authentication, to correctly do so the > * HuC binary must be loaded before the GuC one. > * Loading the HuC is optional; however, not using the HuC might negatively -- Jani Nikula, Intel Open Source Graphics Center