From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA5E7C41513 for ; Wed, 2 Aug 2023 07:28:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qR6HG-0006a7-7b; Wed, 02 Aug 2023 03:28:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qR6HE-0006Rb-Ay for qemu-devel@nongnu.org; Wed, 02 Aug 2023 03:28:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qR6HC-00013F-Rf for qemu-devel@nongnu.org; Wed, 02 Aug 2023 03:28:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690961290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yEiWnlnI0Eq1pfRHmc0LilvBJKTsk3wIzODDpn9ovVQ=; b=QSrSCLW2u5Eq/sYiVvYhehIRoTzbrvTIi/T2tAVtmFAW7m6UYF5roJ1nQCNM++kNGXVgME 4FE6TFYG+cox5dcGSikSFAtYLHxsq8hhyXVoLWllF8fCAVsHru7mB6joHD4WYlSJasxahp 6vWyYDY62+8Afprn5VhmIe7+6jDoISw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-290-f9kJcKJHN_SlAt9Vg5Nnlg-1; Wed, 02 Aug 2023 03:28:08 -0400 X-MC-Unique: f9kJcKJHN_SlAt9Vg5Nnlg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F1BD81DA29; Wed, 2 Aug 2023 07:28:08 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4F9D3492CA6; Wed, 2 Aug 2023 07:28:08 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5F65D21E692A; Wed, 2 Aug 2023 09:28:07 +0200 (CEST) From: Markus Armbruster To: ~hyman Cc: qemu-devel@nongnu.org, ~hyman , Eric Blake , Juan Quintela , Peter Xu , Leonardo Bras Subject: Re: [PATCH QEMU v3 2/3] qapi: Craft the dirty-limit capability comment References: <169073570563.19893.2928364761104733482-2@git.sr.ht> Date: Wed, 02 Aug 2023 09:28:07 +0200 In-Reply-To: <169073570563.19893.2928364761104733482-2@git.sr.ht> (hyman@git.sr.ht's message of "Fri, 28 Jul 2023 23:10:40 +0800") Message-ID: <87fs51sy2g.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org ~hyman writes: > From: Hyman Huang(=E9=BB=84=E5=8B=87) > > Signed-off-by: Markus Armbruster > Signed-off-by: Hyman Huang(=E9=BB=84=E5=8B=87) > --- > qapi/migration.json | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/qapi/migration.json b/qapi/migration.json > index a74ade4d72..62ab151da2 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -519,14 +519,11 @@ > # are present. 'return-path' capability must be enabled to use > # it. (since 8.1) > # > -# @dirty-limit: If enabled, migration will use the dirty-limit > -# algorithim to throttle down guest instead of auto-converge > -# algorithim. Throttle algorithim only works when vCPU's dirtyrate > -# greater than 'vcpu-dirty-limit', read processes in guest os > -# aren't penalized any more, so this algorithim can improve > -# performance of vCPU during live migration. This is an optional > -# performance feature and should not affect the correctness of the > -# existing auto-converge algorithim. (Since 8.1) > +# @dirty-limit: If enabled, migration will throttle vCPUs as needed to > +# keep their dirty page rate within @vcpu-dirty-limit. This can > +# improve responsiveness of large guests during live migration, > +# and can result in more stable read performance. Requires KVM > +# with accelerator property "dirty-ring-size" set. (Since 8.1) > # > # Features: > # Reviewed-by: Markus Armbruster