All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Gustavo Sousa <gustavo.sousa@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915/irq: split out display irq handling
Date: Fri, 12 May 2023 21:21:36 +0300	[thread overview]
Message-ID: <87fs81jtqn.fsf@intel.com> (raw)
In-Reply-To: <168389933649.81732.10815246258922734589@gjsousa-mobl2>

On Fri, 12 May 2023, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
> Quoting Jani Nikula (2023-05-12 07:23:10)
>>Split (non-hotplug) display irq handling out of i915_irq.[ch] into
>>display/intel_display_irq.[ch].
>>
>>v2:
>>- Rebase
>>- Preserve [I915_MAX_PIPES] in functions (kernel test robot)
>>
>>Signed-off-by: Jani Nikula <jani.nikula@intel.com>


>>+void i9xx_pipestat_irq_ack(struct drm_i915_private *i915, u32 iir, u32 *pipe_stats);
>
> I guess this one slipped out when fixing the error diagnosed by "-Werror=array-parameter=".

Indeed, *facepalm*. I'm still rolling with gcc 10, and I believe that
was introduced in gcc 11.

> Used "git show --color-moved ..." to help me review this one and changes look
> sane to me. With the above fixed,
>
> Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

Thanks,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2023-05-12 18:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12 10:23 [Intel-gfx] [PATCH 1/3] drm/i915/irq: convert gen8_de_irq_handler() to void Jani Nikula
2023-05-12 10:23 ` [Intel-gfx] [PATCH 2/3] drm/i915/irq: split out hotplug irq handling Jani Nikula
2023-05-12 10:23 ` [Intel-gfx] [PATCH 3/3] drm/i915/irq: split out display " Jani Nikula
2023-05-12 13:13   ` kernel test robot
2023-05-12 13:13     ` kernel test robot
2023-05-12 13:44   ` kernel test robot
2023-05-12 13:44     ` kernel test robot
2023-05-12 13:48   ` Gustavo Sousa
2023-05-12 18:21     ` Jani Nikula [this message]
2023-05-15 10:05     ` Jani Nikula
2023-05-12 11:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/irq: convert gen8_de_irq_handler() to void Patchwork
2023-05-12 11:52 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-05-12 12:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-12 12:50 ` [Intel-gfx] [PATCH 1/3] " Gustavo Sousa
  -- strict thread matches above, loose matches on Subject: below --
2023-05-04 16:57 [Intel-gfx] [PATCH 0/3] drm/i915: hotplug and display irq refactoring Jani Nikula
2023-05-04 16:57 ` [Intel-gfx] [PATCH 3/3] drm/i915/irq: split out display irq handling Jani Nikula
2023-05-04 18:42   ` kernel test robot
2023-05-04 18:42     ` kernel test robot
2023-05-04 20:15   ` kernel test robot
2023-05-04 20:15     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs81jtqn.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.