All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
To: "Stephan Müller" <smueller@chronox.de>
Cc: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
	Vladis Dronov <vdronov@redhat.com>
Subject: Re: [PATCH v4] crypto: jitter - permanent and intermittent health errors
Date: Mon, 27 Mar 2023 13:40:07 -0300	[thread overview]
Message-ID: <87fs9qnnuq.fsf@canonical.com> (raw)
In-Reply-To: <4478169.LvFx2qVVIh@positron.chronox.de>


It looks good to me too.

I also did a quick smoke test using AF_ALG and I didn't find any issues.

Average of 10 runs doing a million reads of 8, 32, 64 and 128 bytes each
time with drbg_nopr_sha256.

Without the patch:

bsize  count    total (secs)  user (secs)  system (secs)
8      1000000  3,739         0,483        3,247
32     1000000  3,835         0,49         3,337
64     1000000  4,652         0,502        4,14
128    1000000  6,3           0,562        5,73

With the patch:

bsize  count    total (secs)  user (secs)  system (secs)
8      1000000  3,376         0,429        2,936
32     1000000  3,361         0,422        2,927
64     1000000  4,072         0,446        3,614
128    1000000  5,439         0,424        4,981

Reviewed-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>

--
Regards,
Marcelo

  reply	other threads:[~2023-03-27 16:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23  7:17 [PATCH] crypto: Jitter RNG - Permanent and Intermittent health errors Stephan Müller
2023-03-24  9:27 ` Herbert Xu
2023-03-24 12:01   ` Stephan Mueller
2023-03-24 12:30 ` [PATCH v2] " Stephan Müller
2023-03-24 16:03   ` kernel test robot
2023-03-24 17:00 ` [PATCH v3] " Stephan Müller
2023-03-24 17:47   ` Vladis Dronov
2023-03-24 17:54     ` Stephan Mueller
2023-03-25 14:44       ` Vladis Dronov
2023-03-26  8:51         ` Stephan Müller
2023-03-27  7:03 ` [PATCH v4] crypto: jitter - permanent and intermittent " Stephan Müller
2023-03-27 16:40   ` Marcelo Henrique Cerri [this message]
2023-04-06  8:50   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs9qnnuq.fsf@canonical.com \
    --to=marcelo.cerri@canonical.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=smueller@chronox.de \
    --cc=vdronov@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.