From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Samuel Holland <samuel@sholland.org>, u-boot@lists.denx.de
Cc: Samuel Holland <samuel@sholland.org>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Sean Anderson <sean.anderson@seco.com>,
Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH] fastboot: Only call the bootm command if it is enabled
Date: Wed, 22 Feb 2023 14:17:29 +0100 [thread overview]
Message-ID: <87fsax4z6e.fsf@baylibre.com> (raw)
In-Reply-To: <20230220061458.43549-1-samuel@sholland.org>
On lun., févr. 20, 2023 at 00:14, Samuel Holland <samuel@sholland.org> wrote:
> This fixes an error with trying to link against do_bootm() when
> CONFIG_CMD_BOOTM is disabled.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
>
> drivers/fastboot/fb_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
> index 57b6182c46a..20aa80838ae 100644
> --- a/drivers/fastboot/fb_common.c
> +++ b/drivers/fastboot/fb_common.c
> @@ -135,7 +135,7 @@ void fastboot_boot(void)
> s = env_get("fastboot_bootcmd");
> if (s) {
> run_command(s, CMD_FLAG_ENV);
> - } else {
> + } else if (IS_ENABLED(CONFIG_CMD_BOOTM)) {
> static char boot_addr_start[20];
> static char *const bootm_args[] = {
> "bootm", boot_addr_start, NULL
> --
> 2.39.2
next prev parent reply other threads:[~2023-02-22 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 6:14 [PATCH] fastboot: Only call the bootm command if it is enabled Samuel Holland
2023-02-22 13:17 ` Mattijs Korpershoek [this message]
2023-02-22 19:27 ` Patrick DELAUNAY
2023-06-01 15:24 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsax4z6e.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=patrick.delaunay@foss.st.com \
--cc=samuel@sholland.org \
--cc=sean.anderson@seco.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.