From: Markus Armbruster <armbru@redhat.com>
To: Song Gao <gaosong@loongson.cn>
Cc: qemu-devel@nongnu.org, richard.henderson@linaro.org,
peter.maydell@linaro.org, philmd@linaro.org, thuth@redhat.com,
mst@redhat.com, maobibo@loongson.cn, yangxiaojuan@loongson.cn
Subject: Re: [PATCH v1 2/2] loongarch: Add smbios command line option.
Date: Wed, 08 Feb 2023 11:26:13 +0100 [thread overview]
Message-ID: <87fsbglagq.fsf@pond.sub.org> (raw)
In-Reply-To: <20230208094133.2945979-2-gaosong@loongson.cn> (Song Gao's message of "Wed, 8 Feb 2023 17:41:33 +0800")
Song Gao <gaosong@loongson.cn> writes:
> LoongArch has enabled CONFIG_SMBIOS, but didn't enable CLI '-smbios'.
>
Suggest
Fixes: 3efa6fa1e629 ("hw/loongarch: Add smbios support")
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 88e93c6103..2aa6709466 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2592,7 +2592,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios,
> " specify SMBIOS type 17 fields\n"
> "-smbios type=41[,designation=str][,kind=str][,instance=%d][,pcidev=str]\n"
> " specify SMBIOS type 41 fields\n",
> - QEMU_ARCH_I386 | QEMU_ARCH_ARM)
> + QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH)
> SRST
> ``-smbios file=binary``
> Load SMBIOS entry from binary file.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
prev parent reply other threads:[~2023-02-08 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 9:41 [PATCH v1 1/2] docs/system/loongarch: update loongson3.rst and rename it to virt.rst Song Gao
2023-02-08 9:41 ` [PATCH v1 2/2] loongarch: Add smbios command line option Song Gao
2023-02-08 9:51 ` Michael S. Tsirkin
2023-02-08 10:26 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsbglagq.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=gaosong@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.