Re: [PATCH 6.2-rc3] wifi: mt76: fix dma error

[Kalle Valo <kvalo@kernel.org>]

"Linux kernel regression tracking (Thorsten Leemhuis)"
<regressions@leemhuis.info> writes:

> [CCing Felix]
>
> On 10.01.23 23:39, Bert Karwatzki wrote:
>> Since linux-6.2-rc1 the mediatek mt76 wlan driver suffers from problems
>> https://bugzilla.kernel.org/show_bug.cgi?id=216901. I bisected this to
>> commit cd372b8c99c5a5cf6a464acebb7e4a79af7ec8ae and noticed that the
>> 
>> 	if (txwi) {
>> 		q->entry[q->head].txwi = DMA_DUMMY_DATA;
>> 		q->entry[q->head].skip_buf0 = true;
>> 	}
>> 
>> part is moved from the beginning of mt76_dma_add_buf to the
>> inside of the for loop. But q->head is modified at the beginning of
>> this loop.
>
> Thx for your patch. TWIMC, a earlier (and tested) patch to address that
> regression can afaics be found here:
>
> https://lore.kernel.org/lkml/3cb53fbd-0bee-22f9-bba2-6ac4a87db521@nbd.name/
>
> Makes me wonder: Felix, btw, did you ever properly submit that patch for
> inclusion? Where? I can't find it with lore. :-/ Or will it be addressed
> by a different patch?

The patch is now in my queue:

https://patchwork.kernel.org/project/linux-wireless/patch/20230113105848.34642-3-nbd@nbd.name/

> /me really hopes we can get this resolved this week before rc4 ships, as
> it seems this regressions bothers quite a few people

If all goes well this should make it to v6.2-rc5.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches