From: Fabiano Rosas <farosas@suse.de>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Peter Lieven" <pl@kamp.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
"Hanna Reitz" <hreitz@redhat.com>,
libvir-list@redhat.com, "Kevin Wolf" <kwolf@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
qemu-block@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH 1/3] block: mention 'password-secret' option for -iscsi
Date: Thu, 01 Dec 2022 09:58:12 -0300 [thread overview]
Message-ID: <87fsdz5li3.fsf@suse.de> (raw)
In-Reply-To: <20221201101959.419545-2-berrange@redhat.com>
Daniel P. Berrangé <berrange@redhat.com> writes:
> The 'password-secret' option was added
>
> commit b189346eb1784df95ed6fed610411dbf23d19e1f
> Author: Daniel P. Berrangé <berrange@redhat.com>
> Date: Thu Jan 21 14:19:21 2016 +0000
>
> iscsi: add support for getting CHAP password via QCryptoSecret API
>
> but was not mentioned in the command line docs
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 7f99d15b23..055df73306 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1889,7 +1889,7 @@ SRST
> ERST
>
> DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi,
> - "-iscsi [user=user][,password=password]\n"
> + "-iscsi [user=user][,password=password],password-secret=secret-id]\n"
Loos like you're missing a bracket before the comma.
The line below also lacks one at the end.
> " [,header-digest=CRC32C|CR32C-NONE|NONE-CRC32C|NONE\n"
> " [,initiator-name=initiator-iqn][,id=target-iqn]\n"
> " [,timeout=timeout]\n"
next prev parent reply other threads:[~2022-12-01 12:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 10:19 [PATCH 0/3] More work on deprecation/removal of clear text passwords Daniel P. Berrangé
2022-12-01 10:19 ` [PATCH 1/3] block: mention 'password-secret' option for -iscsi Daniel P. Berrangé
2022-12-01 12:58 ` Fabiano Rosas [this message]
2022-12-16 11:18 ` Daniel P. Berrangé
2022-12-01 10:19 ` [PATCH 2/3] block: deprecate iSCSI 'password' in favour of 'password-secret' Daniel P. Berrangé
2022-12-01 12:24 ` Markus Armbruster
2022-12-01 10:19 ` [PATCH 3/3] ui: remove deprecated 'password' option for SPICE Daniel P. Berrangé
2022-12-01 12:16 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsdz5li3.fsf@suse.de \
--to=farosas@suse.de \
--cc=berrange@redhat.com \
--cc=hreitz@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.