From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH 1/3] package/socat: fix printf feature detection
Date: Tue, 01 Nov 2022 22:43:50 +0200 [thread overview]
Message-ID: <87fsf21jyu.fsf@tarshish> (raw)
In-Reply-To: <20221101212917.19567f3f@windsurf>
Hi Thomas,
On Tue, Nov 01 2022, Thomas Petazzoni wrote:
> On Tue, 1 Nov 2022 09:41:54 +0200
> Baruch Siach via buildroot <buildroot@buildroot.org> wrote:
>
>> socal configure uses AC_TRY_RUN to detect printf features. This does not
>> work for cross compilation.
>>
>> All C libraries we use support C99 snprintf. Only glibc and uClibc
>> support the deprecated Z modifier.
>>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>> package/socat/socat.mk | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>
> How did you notice this issue? I see no autobuilder failure. If it
> wasn't working for cross-compilation, we should have build failures, no?
>
> Or are bad results of these ./configure tests only causing runtime
> issues? Could you elaborate a bit?
We are just getting wrong result that leads to sub-optimal code. The
build does not break though. I noticed the issue by looking for
AC_TRY_RUN in configure.ac.
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-11-01 20:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 7:41 [Buildroot] [PATCH 1/3] package/socat: fix printf feature detection Baruch Siach via buildroot
2022-11-01 7:41 ` [Buildroot] [PATCH 2/3] package/socat: disable openssl for static build Baruch Siach via buildroot
2022-11-01 20:32 ` Thomas Petazzoni via buildroot
2022-11-01 20:47 ` Baruch Siach via buildroot
2022-11-01 20:58 ` Thomas Petazzoni via buildroot
2022-11-02 4:43 ` Baruch Siach via buildroot
2022-11-05 22:49 ` Thomas Petazzoni via buildroot
2022-11-14 19:38 ` Peter Korsgaard
2022-11-01 7:41 ` [Buildroot] [PATCH 3/3] package/socat: bump to version 1.7.4.4 Baruch Siach via buildroot
2022-11-05 22:50 ` Thomas Petazzoni via buildroot
2022-11-01 20:29 ` [Buildroot] [PATCH 1/3] package/socat: fix printf feature detection Thomas Petazzoni via buildroot
2022-11-01 20:43 ` Baruch Siach via buildroot [this message]
2022-11-05 22:49 ` Thomas Petazzoni via buildroot
2022-11-14 19:37 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsf21jyu.fsf@tarshish \
--to=buildroot@buildroot.org \
--cc=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.