From: Markus Armbruster <armbru@redhat.com>
To: Alberto Faria <afaria@redhat.com>
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] block/blkio: Make driver nvme-io_uring take a "path" instead of a "filename"
Date: Sat, 29 Oct 2022 08:05:23 +0200 [thread overview]
Message-ID: <87fsf7f9lo.fsf@pond.sub.org> (raw)
In-Reply-To: <20221028233854.839933-1-afaria@redhat.com> (Alberto Faria's message of "Sat, 29 Oct 2022 00:38:54 +0100")
Alberto Faria <afaria@redhat.com> writes:
> The nvme-io_uring driver expects a character special file such as
> /dev/ng0n1. Follow the convention of having a "filename" option when a
> regular file is expected, and a "path" option otherwise.
I suspect this is by accident, not by design. Is it desirable?
> This makes io_uring the only libblkio-based driver with a "filename"
> option, as it accepts a regular file (even though it can also take a
> block special file).
>
> Signed-off-by: Alberto Faria <afaria@redhat.com>
Patch does not apply to master (344744e148e). What's your base?
next prev parent reply other threads:[~2022-10-29 6:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 23:38 [PATCH] block/blkio: Make driver nvme-io_uring take a "path" instead of a "filename" Alberto Faria
2022-10-29 6:05 ` Markus Armbruster [this message]
2022-10-29 9:50 ` Alberto Faria
2022-10-31 18:23 ` Stefan Hajnoczi
2022-10-31 18:35 ` Stefan Hajnoczi
2022-11-02 9:21 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsf7f9lo.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=afaria@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.