From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18686ECAAD1 for ; Tue, 30 Aug 2022 06:03:28 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9800E1636; Tue, 30 Aug 2022 08:02:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9800E1636 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1661839406; bh=scbE8ehsHr7Z1ut1Dmq992GDWMpTXHftD0X4+wE17sE=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LATA6jvOoa76/7O5BcRQJXf0ND1Thrqnb1bPiOPk9rCdB2aiCL8RdiwGYGWSbasxe YOAJvO/gkJIdqa10hlCkt4AbHCw4rKlzaJ6KhRR5ntxYfNuP6zBiAbdB3sd3Aeil21 8u3x2WcXxZ8B+8tST4RpwZvV+ii5EMl9eYVh0kIc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 359E3F8016B; Tue, 30 Aug 2022 08:02:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id ED5A6F8023A; Tue, 30 Aug 2022 08:02:34 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4AC1EF800F2 for ; Tue, 30 Aug 2022 08:02:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4AC1EF800F2 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Io3eKnT+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="mj31RReu" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B8A3021C7F; Tue, 30 Aug 2022 06:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1661839350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZejuxAE1PQj9TmfRj/5fR/1vUWJtX8c2vAfHVZke/pU=; b=Io3eKnT+yrfW4tKX2EgYZHI2nIIbRmUAHmHsB0tY93jGcAuLaOxcMAlaapwj8y/hxltr3Y g29mLuvO6SQr/oj98/PQJeU+Kny6kcdxSZhj5c9c9QBGodCD/MgcNp3rmDnJx5AxeuCEx7 RaC7ql3nxsJ/xvTObtiZPYvCcqsLQiI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1661839350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZejuxAE1PQj9TmfRj/5fR/1vUWJtX8c2vAfHVZke/pU=; b=mj31RReuaXOOWc7Qn8u9f9qryTgeUOYoNvlqfvQFknpoUaoAUlogi/nnuqjClrhDLgpQIv 5nT2qkPeiUBr0JBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9CB9F13B0C; Tue, 30 Aug 2022 06:02:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id FIB+JfanDWMrFwAAMHmgww (envelope-from ); Tue, 30 Aug 2022 06:02:30 +0000 Date: Tue, 30 Aug 2022 08:02:30 +0200 Message-ID: <87fshe8e15.wl-tiwai@suse.de> From: Takashi Iwai To: chihhao chen Subject: Re: missing sound on kernel-5.15 In-Reply-To: <87ilma8edo.wl-tiwai@suse.de> References: <87e6d6ae69d68dc588ac9acc8c0f24d6188375c3.camel@mediatek.com> <120e52d94c00aab2cf1f3d611b06f03356e8229f.camel@mediatek.com> <87r10zxyml.wl-tiwai@suse.de> <87a67nb5yc.wl-tiwai@suse.de> <87r10y9are.wl-tiwai@suse.de> <87ilma8edo.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 30 Aug 2022 07:54:59 +0200, Takashi Iwai wrote: > > On Mon, 29 Aug 2022 20:15:33 +0200, > Takashi Iwai wrote: > > > > On Mon, 29 Aug 2022 14:16:27 +0200, > > Takashi Iwai wrote: > > > > > > On Mon, 29 Aug 2022 10:50:58 +0200, > > > chihhao chen wrote: > > > > > > > > Hi Takashi, > > > > > > > > Yes. > > > > > > > > To issue SAMPLING_FREQ_CONTROL USB request two times is root cause of > > > > this issue. > > > > > > Hm, is it a UAC1 device? Such a device should work with multiple > > > SAMPLING_FREQ_CONTROL invocations, but some device might be not > > > tolerant or buggy... The multiple init_sample_rate() invocations may > > > happen with the older kernel under certain situations, so maybe we > > > need a different fix. > > > > > > How about the patch like below? > > > > It's missing the clearance for suspend/resume. > > The revised patch is below. > > ... and after reading the mail again, I noticed that it's all > rubbish, scratch the previous ones. > > Have you tested it with the later kernel? I guess this has been > already addressed. In the recent kernel, the rate is set per assigned > clock, hence it won't be set up twice unnecessarily. That said, try to cherry-pick the upstream commit c11117b634f4f832c4420d3cf41c44227f140ce1. If this is confirmed to work, we can ask Greg to merge it into 5.15.y stable tree. Takashi