From: Cornelia Huck <cohuck@redhat.com>
To: Abhishek Sahu <abhsahu@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>
Cc: Yishai Hadas <yishaih@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Kevin Tian <kevin.tian@intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-pm@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v5 1/5] vfio: Add the device features for the low power entry and exit
Date: Tue, 26 Jul 2022 15:13:07 +0200 [thread overview]
Message-ID: <87fsiom2zg.fsf@redhat.com> (raw)
In-Reply-To: <bd7bca18-ae07-c04a-23d3-bf71245da0cc@nvidia.com>
On Tue, Jul 26 2022, Abhishek Sahu <abhsahu@nvidia.com> wrote:
> #define VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP 4
>
> /*
> * Upon VFIO_DEVICE_FEATURE_SET, disallow use of device low power states as
> * previously enabled via VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY or
> * VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP device features.
> * This device feature IOCTL may itself generate a wakeup eventfd notification
> * in the latter case if the device has previously entered a low power state.
Nit: s/has/had/
> */
> #define VFIO_DEVICE_FEATURE_LOW_POWER_EXIT 5
I haven't followed this closely, and I'm not that familiar with power
management, but at least I can't spot anything obviously problematic.
next prev parent reply other threads:[~2022-07-26 13:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 12:15 [PATCH v5 0/5] vfio/pci: power management changes Abhishek Sahu
2022-07-19 12:15 ` [PATCH v5 1/5] vfio: Add the device features for the low power entry and exit Abhishek Sahu
2022-07-21 22:34 ` Alex Williamson
2022-07-25 14:40 ` Abhishek Sahu
2022-07-25 22:09 ` Alex Williamson
2022-07-26 12:47 ` Abhishek Sahu
2022-07-26 13:13 ` Cornelia Huck [this message]
2022-07-26 14:17 ` Alex Williamson
2022-07-26 17:23 ` Jason Gunthorpe
2022-07-27 6:07 ` Abhishek Sahu
2022-08-01 18:42 ` Alex Williamson
2022-08-02 14:04 ` Jason Gunthorpe
2022-08-02 15:41 ` Alex Williamson
2022-08-02 16:35 ` Jason Gunthorpe
2022-08-02 16:57 ` Alex Williamson
2022-08-02 17:01 ` Jason Gunthorpe
2022-08-03 6:32 ` Abhishek Sahu
2022-07-19 12:15 ` [PATCH v5 2/5] vfio: Increment the runtime PM usage count during IOCTL call Abhishek Sahu
2022-07-21 22:34 ` Alex Williamson
2022-07-19 12:15 ` [PATCH v5 3/5] vfio/pci: Mask INTx during runtime suspend Abhishek Sahu
2022-07-19 12:15 ` [PATCH v5 4/5] vfio/pci: Implement VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY/EXIT Abhishek Sahu
2022-07-21 22:34 ` Alex Williamson
2022-07-25 14:48 ` Abhishek Sahu
2022-07-19 12:15 ` [PATCH v5 5/5] vfio/pci: Implement VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP Abhishek Sahu
2022-07-21 22:34 ` Alex Williamson
2022-07-25 15:04 ` Abhishek Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsiom2zg.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=abhsahu@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=rafael@kernel.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.