From: "Alex Bennée" <alex.bennee@linaro.org>
To: Shaobo Song <shnusongshaobo@gmail.com>
Cc: richard.henderson@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] tcg: Fix returned type in alloc_code_gen_buffer_splitwx_memfd()
Date: Sat, 25 Jun 2022 17:32:42 +0100 [thread overview]
Message-ID: <87fsjsaekv.fsf@linaro.org> (raw)
In-Reply-To: <20220624150216.3627-1-shnusongshaobo@gmail.com>
Shaobo Song <shnusongshaobo@gmail.com> writes:
> This fixes a bug in POSIX-compliant environments. Since we had allocated
> a buffer named 'tcg-jit' with read-write access protections we need a int
> type to combine these access flags and return it, whereas we had inexplicably
> return a bool type. It may cause an unnecessary protection change in
> tcg_region_init().
>
> Signed-off-by: Shaobo Song <shnusongshaobo@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2022-06-25 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 15:02 [PATCH] tcg: Fix returned type in alloc_code_gen_buffer_splitwx_memfd() Shaobo Song
2022-06-25 16:32 ` Alex Bennée [this message]
2022-06-26 10:49 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsjsaekv.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shnusongshaobo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.