From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35146C433EF for ; Mon, 28 Mar 2022 09:34:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236654AbiC1Jfi (ORCPT ); Mon, 28 Mar 2022 05:35:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232922AbiC1Jfi (ORCPT ); Mon, 28 Mar 2022 05:35:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E07C0DFAE; Mon, 28 Mar 2022 02:33:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 763D060F04; Mon, 28 Mar 2022 09:33:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE0B4C004DD; Mon, 28 Mar 2022 09:33:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648460036; bh=vyhorH3ReopEjyyeOaqNXz1F+fuDMA3PtzKea0coFV8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=N7gslZiAbUk2K0itCjecfsI/RWbD921JgzGNP2Kjob9tlNWKxpcv0XxXJfPNZin/w A0IR7YQPjfgzcF8nfIw2Qp9ZjcFTNb7LTztL9AYoQlq+D0DFSUCrNS2qiH6JPnE1fC d1KCYuVMQdA55JmSSOhMn38gdsnsuJiIvXS7xjuBjd+D58bh2S8/2S5hzqSNDwuMtF wL6A4k/3MHLny+7jUG8f45x9h9oK0icdinMC+NM7pK2YaZF62B/PFs4TG4m+pXcVBe gM+xB7pqzFL7oswhmEfyYWWLVgaR1DNvn0CsMhOvyHk4QEK83ayzd9+XQz5ZI40AA0 C+vN55O6TsHMw== From: Kalle Valo To: Benjamin =?utf-8?Q?St=C3=BCrz?= Cc: sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, linux@armlinux.org.uk, linux@simtec.co.uk, krzk@kernel.org, alim.akhtar@samsung.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, robert.moore@intel.com, rafael.j.wysocki@intel.com, lenb@kernel.org, 3chas3@gmail.com, laforge@gnumonks.org, arnd@arndb.de, gregkh@linuxfoundation.org, mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, mike.marciniszyn@cornelisnetworks.com, dennis.dalessandro@cornelisnetworks.com, jgg@ziepe.ca, pali@kernel.org, dmitry.torokhov@gmail.com, isdn@linux-pingi.de, benh@kernel.crashing.org, fbarrat@linux.ibm.com, ajd@linux.ibm.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, nico@fluxnic.net, loic.poulain@linaro.org, pkshih@realtek.com, bhelgaas@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-media@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 00/22] Replace comments with C99 initializers References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> Date: Mon, 28 Mar 2022 12:33:42 +0300 In-Reply-To: <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> ("Benjamin \=\?utf-8\?Q\?St\=C3\=BCrz\=22's\?\= message of "Sun, 27 Mar 2022 14:46:00 +0200") Message-ID: <87fsn2zaix.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Benjamin St=C3=BCrz writes: > This patch series replaces comments with C99's designated initializers > in a few places. It also adds some enum initializers. This is my first > time contributing to the Linux kernel, therefore I'm probably doing a > lot of things the wrong way. I'm sorry for that. Just a small tip: If you are new, start with something small and learn from that. Don't do a controversial big patchset spanning multiple subsystems, that's the hard way to learn things. First submit one patch at a time to one subsystem and gain understanding of the process that way. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Mon, 28 Mar 2022 09:33:42 +0000 Subject: Re: [PATCH 00/22] Replace comments with C99 initializers Message-Id: <87fsn2zaix.fsf@kernel.org> List-Id: References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> In-Reply-To: <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> ("Benjamin \=\?utf-8\?Q\?St\=C3\=BCrz\=22's\?\= message of "Sun, 27 Mar 2022 14:46:00 +0200") MIME-Version: 1.0 Content-Type: text/plain; charset="macroman" Content-Transfer-Encoding: base64 To: Benjamin =?utf-8?Q?St=C3=BCrz?= Cc: sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, linux@armlinux.org.uk, linux@simtec.co.uk, krzk@kernel.org, alim.akhtar@samsung.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, robert.moore@intel.com, rafael.j.wysocki@intel.com, lenb@kernel.org, 3chas3@gmail.com, laforge@gnumonks.org, arnd@arndb.de, gregkh@linuxfoundation.org, mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, mike.marciniszyn@cornelisnetworks.com, dennis.dalessandro@cornelisnetworks.com, jgg@ziepe.ca, pali@kernel.org, dmitry.torokhov@gmail.com, isdn@linux-pingi.de, benh@kernel.crashing.org, fbarrat@linux.ibm.com, ajd@linux.ibm.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, nico@fluxnic.net, loic.poulain@linaro.org, pkshih@realtek.com, bhelgaas@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-media@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org QmVuamFtaW4gU3TDvHJ6IDxiZW5uaUBzdHVlcnoueHl6PiB3cml0ZXM6Cgo+IFRoaXMgcGF0Y2gg c2VyaWVzIHJlcGxhY2VzIGNvbW1lbnRzIHdpdGggQzk5J3MgZGVzaWduYXRlZCBpbml0aWFsaXpl cnMKPiBpbiBhIGZldyBwbGFjZXMuIEl0IGFsc28gYWRkcyBzb21lIGVudW0gaW5pdGlhbGl6ZXJz LiBUaGlzIGlzIG15IGZpcnN0Cj4gdGltZSBjb250cmlidXRpbmcgdG8gdGhlIExpbnV4IGtlcm5l bCwgdGhlcmVmb3JlIEknbSBwcm9iYWJseSBkb2luZyBhCj4gbG90IG9mIHRoaW5ncyB0aGUgd3Jv bmcgd2F5LiBJJ20gc29ycnkgZm9yIHRoYXQuCgpKdXN0IGEgc21hbGwgdGlwOiBJZiB5b3UgYXJl IG5ldywgc3RhcnQgd2l0aCBzb21ldGhpbmcgc21hbGwgYW5kIGxlYXJuCmZyb20gdGhhdC4gRG9u J3QgZG8gYSBjb250cm92ZXJzaWFsIGJpZyBwYXRjaHNldCBzcGFubmluZyBtdWx0aXBsZQpzdWJz eXN0ZW1zLCB0aGF0J3MgdGhlIGhhcmQgd2F5IHRvIGxlYXJuIHRoaW5ncy4gRmlyc3Qgc3VibWl0 IG9uZSBwYXRjaAphdCBhIHRpbWUgdG8gb25lIHN1YnN5c3RlbSBhbmQgZ2FpbiB1bmRlcnN0YW5k aW5nIG9mIHRoZSBwcm9jZXNzIHRoYXQKd2F5LgoKLS0gCmh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5l bC5vcmcvcHJvamVjdC9saW51eC13aXJlbGVzcy9saXN0LwoKaHR0cHM6Ly93aXJlbGVzcy53aWtp Lmtlcm5lbC5vcmcvZW4vZGV2ZWxvcGVycy9kb2N1bWVudGF0aW9uL3N1Ym1pdHRpbmdwYXRjaGVz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41214C433EF for ; Mon, 28 Mar 2022 10:58:00 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KRqRV5vG6z3c6d for ; Mon, 28 Mar 2022 21:57:58 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=N7gslZiA; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4601:e00::1; helo=ams.source.kernel.org; envelope-from=kvalo@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=N7gslZiA; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KRnZf4SR5z2xSM for ; Mon, 28 Mar 2022 20:34:02 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F242CB80FCD; Mon, 28 Mar 2022 09:33:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE0B4C004DD; Mon, 28 Mar 2022 09:33:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648460036; bh=vyhorH3ReopEjyyeOaqNXz1F+fuDMA3PtzKea0coFV8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=N7gslZiAbUk2K0itCjecfsI/RWbD921JgzGNP2Kjob9tlNWKxpcv0XxXJfPNZin/w A0IR7YQPjfgzcF8nfIw2Qp9ZjcFTNb7LTztL9AYoQlq+D0DFSUCrNS2qiH6JPnE1fC d1KCYuVMQdA55JmSSOhMn38gdsnsuJiIvXS7xjuBjd+D58bh2S8/2S5hzqSNDwuMtF wL6A4k/3MHLny+7jUG8f45x9h9oK0icdinMC+NM7pK2YaZF62B/PFs4TG4m+pXcVBe gM+xB7pqzFL7oswhmEfyYWWLVgaR1DNvn0CsMhOvyHk4QEK83ayzd9+XQz5ZI40AA0 C+vN55O6TsHMw== From: Kalle Valo To: Benjamin =?utf-8?Q?St=C3=BCrz?= Subject: Re: [PATCH 00/22] Replace comments with C99 initializers References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> Date: Mon, 28 Mar 2022 12:33:42 +0300 In-Reply-To: <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> ("Benjamin \=\?utf-8\?Q\?St\=C3\=BCrz\=22's\?\= message of "Sun, 27 Mar 2022 14:46:00 +0200") Message-ID: <87fsn2zaix.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Mon, 28 Mar 2022 21:56:49 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-atm-general@lists.sourceforge.net, linux-ia64@vger.kernel.org, linus.walleij@linaro.org, dave.hansen@linux.intel.com, linux-pci@vger.kernel.org, robert.moore@intel.com, laforge@gnumonks.org, alim.akhtar@samsung.com, hpa@zytor.com, wcn36xx@lists.infradead.org, pkshih@realtek.com, linux-samsung-soc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, dennis.dalessandro@cornelisnetworks.com, linux-rdma@vger.kernel.org, gregory.clement@bootlin.com, rafael.j.wysocki@intel.com, linux@armlinux.org.uk, krzk@kernel.org, jgg@ziepe.ca, mingo@redhat.com, 3chas3@gmail.com, linux-input@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com, lenb@kernel.org, mike.marciniszyn@cornelisnetworks.com, rric@kernel.org, ajd@linux.ibm.com, arnd@arndb.de, linuxppc-dev@lists.ozlabs.org, linux-gpio@vger.kernel.org, loic.poulain@linaro.org, bp@alien8.de, bhelgaas@google.com, tglx@linutronix.de, mchehab@kernel.org, linux-media@vger.kernel.org, linux@simtec.co.uk, linux-arm-kernel@lists.infradead.org, devel@acpica.org, isdn@linux-pingi.de, tony.luck@intel.com, nico@fluxnic.net, gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, james.morse@arm.com, netdev@vger.kernel.org, fbarrat@linux.ibm.com, sebastian.hesselbarth@gmail.com, pali@kernel.org, brgl@bgdev.pl Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Benjamin St=C3=BCrz writes: > This patch series replaces comments with C99's designated initializers > in a few places. It also adds some enum initializers. This is my first > time contributing to the Linux kernel, therefore I'm probably doing a > lot of things the wrong way. I'm sorry for that. Just a small tip: If you are new, start with something small and learn from that. Don't do a controversial big patchset spanning multiple subsystems, that's the hard way to learn things. First submit one patch at a time to one subsystem and gain understanding of the process that way. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes